diff --git a/.github/workflows/deployment.yml b/.github/workflows/deployment.yml index 15faa88cf..b9386e7de 100644 --- a/.github/workflows/deployment.yml +++ b/.github/workflows/deployment.yml @@ -1,13 +1,6 @@ name: Deploy to EC2 on: workflow_dispatch: # allow manual run - push: - branches: - - master - paths: - - 'src/**' - - 'public/**' - - 'editor/**' jobs: deploy: runs-on: ubuntu-latest diff --git a/contributing.md b/contributing.md index 883a5ffc3..48475098c 100644 --- a/contributing.md +++ b/contributing.md @@ -2,23 +2,11 @@ First of all thank you for considering to contribute. Please look at the details below: -- [Create a New Branch](#create-a-new-branch) - [New Roadmaps](#new-roadmaps) - [Existing Roadmaps](#existing-roadmaps) - [Adding Content](#adding-content) - [Guidelines](#guidelines) -## Create A New Branch - -To create a new branch against `develop` for your contribution please do the following: - -```bash -git clone https://github.com/kamranahmedse/developer-roadmap.git # Clone Repo -cd developer-roadmap # Change Directory -git switch develop && git pull # Switch and pull -git checkout -b "a-sensible-branch-name" # Create your branch -``` - ## New Roadmaps For new roadmaps, you can either: @@ -58,10 +46,6 @@ Visit the following resources to learn more: ## Guidelines --

Please open your pull request (PR) against the develop branch.
- - To keep caching and deployments under control, please open your PR's against the `develop` branch, which will then be merged into `master` at the end of the day. - -

Adding everything available out there is not the goal!
The roadmaps represent the skillset most valuable today, i.e., if you were to enter any of the listed fields today, what would you learn? There might be things that are of-course being used today but prioritize the things that are most in demand today, e.g., agreed that lots of people are using angular.js today but you wouldn't want to learn that instead of React, Angular, or Vue. Use your critical thinking to filter out non-essential stuff. Give honest arguments for why the resource should be included.