From 7b9e6ed079eee7fbf1446269cd7dcff178a368c5 Mon Sep 17 00:00:00 2001
From: Kamran Ahmed <kamranahmed.se@gmail.com>
Date: Thu, 1 May 2025 23:18:08 +0100
Subject: [PATCH] Refactor topic popup

---
 src/components/TopicDetail/TopicDetail.tsx    | 44 ++++++-----------
 .../TopicDetail/TopicDetailLink.tsx           | 48 +++++++++++++++----
 .../TopicDetail/TopicDetailsTabs.tsx          | 23 +++++----
 .../TopicDetail/TopicProgressButton.tsx       | 13 ++---
 ...the-internet-work@yCnn-NfSxIybUQ2iTuUGq.md |  2 +-
 .../content/internet@VlNNwIEDWqQXtqkHWJYzC.md |  2 +-
 6 files changed, 77 insertions(+), 55 deletions(-)

diff --git a/src/components/TopicDetail/TopicDetail.tsx b/src/components/TopicDetail/TopicDetail.tsx
index c524e6f1a..0fef684fa 100644
--- a/src/components/TopicDetail/TopicDetail.tsx
+++ b/src/components/TopicDetail/TopicDetail.tsx
@@ -21,7 +21,7 @@ import type {
   RoadmapContentDocument,
 } from '../CustomRoadmap/CustomRoadmap';
 import { markdownToHtml, sanitizeMarkdown } from '../../lib/markdown';
-import { Ban, Coins, FileText, HeartHandshake, Star, X } from 'lucide-react';
+import { Ban, FileText, HeartHandshake, Star, X } from 'lucide-react';
 import { getUrlParams, parseUrl } from '../../lib/browser';
 import { Spinner } from '../ReactIcons/Spinner';
 import { GitHubIcon } from '../ReactIcons/GitHubIcon.tsx';
@@ -396,29 +396,28 @@ export function TopicDetail(props: TopicDetailProps) {
                 'flex flex-col': activeTab === 'ai',
               })}
             >
-              <div className={cn('mb-6 -mx-6 -mt-6 border-b p-2 flex items-center justify-between')}>
+              <div
+                className={cn(
+                  '-mt-4 mb-2 flex items-center justify-between py-1.5',
+                )}
+              >
                 <div>
-                  {!isEmbed && (
-                    <TopicProgressButton
-                      topicId={
-                        topicId.indexOf('@') !== -1
-                          ? topicId.split('@')[1]
-                          : topicId
-                      }
-                      resourceId={resourceId}
-                      resourceType={resourceType}
-                      onClose={handleClose}
-                    />
-                  )}
+                  <a
+                    href={contributionUrl}
+                    target={'_blank'}
+                    className="flex w-full items-center justify-center rounded-md px-2 py-1 text-sm text-xs text-black transition-colors hover:bg-black hover:text-white disabled:bg-green-200 disabled:text-black"
+                  >
+                    <GitHubIcon className="mr-1.5 inline-block size-[12px] text-current" />
+                    Edit this content
+                  </a>
                 </div>
                 <button
                   type="button"
                   id="close-topic"
-                  className="flex gap-2 items-center rounded-lg bg-transparent p-1.5 text-xs uppercase tracking-wider text-gray-400 hover:bg-gray-200 hover:text-gray-900"
+                  className="flex items-center gap-2 rounded-lg bg-transparent px-1.5 py-1 text-xs tracking-wider text-gray-400 uppercase hover:bg-gray-200 hover:text-gray-900"
                   onClick={handleClose}
                 >
                   <X className="size-4" />
-                  Close
                 </button>
               </div>
 
@@ -560,19 +559,6 @@ export function TopicDetail(props: TopicDetailProps) {
                         })}
                       </ul>
 
-                      {hasPaidScrimbaLinks && (
-                        <div className="relative mt-4 -mb-1 ml-3 rounded-md border border-yellow-300 bg-yellow-100 px-2.5 py-2 text-sm text-yellow-800">
-                          <div className="flex items-center gap-2">
-                            <Coins className="h-4 w-4 text-yellow-700" />
-                            <span>
-                              Scrimba is offering{' '}
-                              <span className={'font-semibold'}>20% off</span>{' '}
-                              on all courses for roadmap.sh users.
-                            </span>
-                          </div>
-                        </div>
-                      )}
-
                       {showPaidResourceDisclaimer && (
                         <PaidResourceDisclaimer
                           onClose={() => {
diff --git a/src/components/TopicDetail/TopicDetailLink.tsx b/src/components/TopicDetail/TopicDetailLink.tsx
index d5b05c95e..60f3ea5e7 100644
--- a/src/components/TopicDetail/TopicDetailLink.tsx
+++ b/src/components/TopicDetail/TopicDetailLink.tsx
@@ -1,7 +1,7 @@
 import { cn } from '../../lib/classname.ts';
 import type { AllowedLinkTypes } from '../CustomRoadmap/CustomRoadmap.tsx';
 
-const linkTypes: Record<AllowedLinkTypes, string> = {
+const linkTypes: Record<AllowedLinkTypes | string, string> = {
   article: 'bg-yellow-300',
   course: 'bg-green-400',
   opensource: 'bg-black text-white',
@@ -18,6 +18,34 @@ const paidLinkTypes: Record<string, string> = {
   course: 'bg-yellow-300',
 };
 
+type TopicLinkBadgeProps = {
+  isPaid: boolean;
+  discountText?: string;
+  type: AllowedLinkTypes | string;
+  className?: string;
+};
+
+function TopicLinkBadge(props: TopicLinkBadgeProps) {
+  const { isPaid, type, className } = props;
+
+  const linkType = type === 'opensource' ? 'OpenSource' : type;
+  const isDiscount = type.includes('% off');
+
+  return (
+    <span className={cn('mr-2', className)}>
+      <span
+        className={cn(
+          'inline-block rounded-sm px-1.5 py-0.5 text-xs capitalize no-underline',
+          (isPaid ? paidLinkTypes[type] : linkTypes[type]) || 'bg-gray-200',
+          isDiscount && 'bg-green-300',
+        )}
+      >
+        {linkType}
+      </span>
+    </span>
+  );
+}
+
 type TopicDetailLinkProps = {
   url: string;
   onClick?: () => void;
@@ -29,7 +57,7 @@ type TopicDetailLinkProps = {
 export function TopicDetailLink(props: TopicDetailLinkProps) {
   const { url, onClick, type, title, isPaid = false } = props;
 
-  const linkType = type === 'opensource' ? 'OpenSource' : type;
+  const isScrimbaLink = url.toLowerCase().includes('scrimba.com');
 
   return (
     <a
@@ -38,14 +66,14 @@ export function TopicDetailLink(props: TopicDetailLinkProps) {
       className="group font-medium text-gray-800 underline underline-offset-1 hover:text-black"
       onClick={onClick}
     >
-      <span
-        className={cn(
-          'mr-2 inline-block rounded-sm px-1.5 py-0.5 text-xs capitalize no-underline',
-          (isPaid ? paidLinkTypes[type] : linkTypes[type]) || 'bg-gray-200',
-        )}
-      >
-        {linkType}
-      </span>
+      <TopicLinkBadge
+        isPaid={isPaid}
+        type={type}
+        discountText={isScrimbaLink ? '20% off' : undefined}
+        className={isScrimbaLink ? 'mr-1' : 'mr-2'}
+      />
+      {isScrimbaLink && <TopicLinkBadge isPaid={isPaid} type="20% off" />}
+
       {title}
     </a>
   );
diff --git a/src/components/TopicDetail/TopicDetailsTabs.tsx b/src/components/TopicDetail/TopicDetailsTabs.tsx
index 855bfe185..d82958056 100644
--- a/src/components/TopicDetail/TopicDetailsTabs.tsx
+++ b/src/components/TopicDetail/TopicDetailsTabs.tsx
@@ -1,4 +1,4 @@
-import { BookIcon, SparklesIcon, type LucideIcon } from 'lucide-react';
+import { Earth, WandSparkles, type LucideIcon } from 'lucide-react';
 
 export type AllowedTopicDetailsTabs = 'content' | 'ai';
 
@@ -11,17 +11,18 @@ export function TopicDetailsTabs(props: TopicDetailsTabsProps) {
   const { activeTab, setActiveTab } = props;
 
   return (
-    <div className="flex w-max items-center gap-1 rounded-lg border border-gray-200 p-0.5">
+    <div className="flex w-max items-center gap-1.5 p-0.5">
       <TopicDetailsTab
         isActive={activeTab === 'content'}
-        icon={BookIcon}
-        label="Content"
+        icon={Earth}
+        label="Resources"
         onClick={() => setActiveTab('content')}
       />
       <TopicDetailsTab
         isActive={activeTab === 'ai'}
-        icon={SparklesIcon}
-        label="Learn with AI"
+        icon={WandSparkles}
+        label="AI Tutor"
+        isNew={true}
         onClick={() => setActiveTab('ai')}
       />
     </div>
@@ -32,15 +33,16 @@ type TopicDetailsTabProps = {
   isActive: boolean;
   icon: LucideIcon;
   label: string;
+  isNew?: boolean;
   onClick: () => void;
 };
 
 function TopicDetailsTab(props: TopicDetailsTabProps) {
-  const { isActive, icon: Icon, label, onClick } = props;
+  const { isActive, icon: Icon, label, isNew, onClick } = props;
 
   return (
     <button
-      className="flex h-7 items-center gap-2 rounded-md px-2 py-0.5 text-sm text-gray-500 data-[state=active]:bg-black data-[state=active]:text-white"
+      className="flex hover:bg-gray-100 items-center gap-2 px-2 py-1 rounded-lg text-sm text-gray-500 data-[state=active]:bg-black data-[state=active]:text-white"
       data-state={isActive ? 'active' : 'inactive'}
       onClick={onClick}
       disabled={isActive}
@@ -48,6 +50,11 @@ function TopicDetailsTab(props: TopicDetailsTabProps) {
     >
       <Icon className="h-4 w-4" />
       {label}
+      {isNew && (
+        <span className="text-xs bg-yellow-400 text-black rounded-sm px-1">
+          New
+        </span>
+      )}
     </button>
   );
 }
diff --git a/src/components/TopicDetail/TopicProgressButton.tsx b/src/components/TopicDetail/TopicProgressButton.tsx
index d3de18842..ecbf6a5a3 100644
--- a/src/components/TopicDetail/TopicProgressButton.tsx
+++ b/src/components/TopicDetail/TopicProgressButton.tsx
@@ -204,6 +204,7 @@ export function TopicProgressButton(props: TopicProgressButtonProps) {
         console.error(err);
       })
       .finally(() => {
+        setShowChangeStatus(false);
         setIsUpdatingProgress(false);
       });
   };
@@ -223,9 +224,9 @@ export function TopicProgressButton(props: TopicProgressButtonProps) {
 
   if (isUpdatingProgress) {
     return (
-      <button className="inline-flex cursor-default items-center rounded-md bg-white p-1 px-2 text-sm text-black">
+      <button className="inline-flex cursor-default items-center rounded-md border border-gray-300 bg-white p-1 px-2 text-sm text-black">
         <Spinner isDualRing={false} className="h-4 w-4" />
-        <span className="ml-2">Updating Status..</span>
+        <span className="ml-2">Please wait..</span>
       </button>
     );
   }
@@ -233,23 +234,23 @@ export function TopicProgressButton(props: TopicProgressButtonProps) {
   return (
     <div className="relative inline-flex">
       <button
+        className="inline-flex cursor-default cursor-pointer items-center rounded-md border border-gray-300 p-1 px-2 text-sm text-black hover:bg-gray-100"
         onClick={() => setShowChangeStatus(true)}
-        className="inline-flex cursor-pointer items-center gap-2 rounded-md p-1 px-2 text-sm text-black hover:bg-gray-100"
       >
         <span className="flex h-2 w-2">
           <span
             className={`relative inline-flex h-2 w-2 rounded-full ${statusColors[progress]}`}
           ></span>
         </span>
-        <span className="capitalize">
+        <span className="ml-2 capitalize">
           {progress === 'learning' ? 'In Progress' : progress}
         </span>
-        <ChevronDown className="h-4 w-4" />
+        <ChevronDown className="ml-2 h-4 w-4" />
       </button>
 
       {showChangeStatus && (
         <div
-          className="absolute top-full left-0 z-50 mt-1 flex min-w-[160px] flex-col divide-y rounded-md border border-gray-200 bg-white shadow-md [&>button:first-child]:rounded-t-md [&>button:last-child]:rounded-b-md"
+          className="absolute bg-white z-50 top-full right-0 mt-1 flex min-w-[160px] flex-col divide-y rounded-md border border-gray-200 bg-white shadow-md [&>button:first-child]:rounded-t-md [&>button:last-child]:rounded-b-md"
           ref={changeStatusRef!}
         >
           {allowMarkingDone && (
diff --git a/src/data/roadmaps/frontend/content/how-does-the-internet-work@yCnn-NfSxIybUQ2iTuUGq.md b/src/data/roadmaps/frontend/content/how-does-the-internet-work@yCnn-NfSxIybUQ2iTuUGq.md
index 458665bb6..a9b391000 100644
--- a/src/data/roadmaps/frontend/content/how-does-the-internet-work@yCnn-NfSxIybUQ2iTuUGq.md
+++ b/src/data/roadmaps/frontend/content/how-does-the-internet-work@yCnn-NfSxIybUQ2iTuUGq.md
@@ -4,7 +4,7 @@ The internet is a global network that connects computers and devices so they can
 
 Visit the following resources to learn more:
 
-- [@roadmap@Introduction to Internet](https://roadmap.sh/guides/what-is-internet)
+- [@article@Introduction to Internet](https://roadmap.sh/guides/what-is-internet)
 - [@article@How does the Internet Work?](https://cs.fyi/guide/how-does-internet-work)
 - [@article@How Does the Internet Work? MDN Docs](https://developer.mozilla.org/en-US/docs/Learn/Common_questions/How_does_the_Internet_work)
 - [@video@How the Internet Works in 5 Minutes](https://www.youtube.com/watch?v=7_LPdttKXPc)
diff --git a/src/data/roadmaps/frontend/content/internet@VlNNwIEDWqQXtqkHWJYzC.md b/src/data/roadmaps/frontend/content/internet@VlNNwIEDWqQXtqkHWJYzC.md
index de067dbaa..f34a4636f 100644
--- a/src/data/roadmaps/frontend/content/internet@VlNNwIEDWqQXtqkHWJYzC.md
+++ b/src/data/roadmaps/frontend/content/internet@VlNNwIEDWqQXtqkHWJYzC.md
@@ -4,5 +4,5 @@ The Internet is a global network of interconnected computer networks that use th
 
 Visit the following resources to learn more:
 
-- [@roadmap@Introduction to Internet](https://roadmap.sh/guides/what-is-internet)
+- [@article@Introduction to Internet](https://roadmap.sh/guides/what-is-internet)
 - [@article@The Internet](https://en.wikipedia.org/wiki/Internet)