Refactor sharer icons

pull/3356/head
Kamran Ahmed 2 years ago
parent 8b3f8ee6b8
commit 8a24b3e695
  1. 2
      src/best-practices/frontend-performance/frontend-performance.md
  2. 2
      src/pages/[roadmapId]/index.astro
  3. 2
      src/pages/best-practices/[bestPracticeId].astro

@ -3,7 +3,7 @@ jsonUrl: "/jsons/best-practices/frontend-performance.json"
pdfUrl: "/pdfs/best-practices/frontend-performance.pdf" pdfUrl: "/pdfs/best-practices/frontend-performance.pdf"
order: 1 order: 1
featuredTitle: "Frontend Performance" featuredTitle: "Frontend Performance"
featuredDescription: "Detailed list of best practices to improve your frontend performance" featuredDescription: "Frontend Performance Best Practices"
isNew: true isNew: true
isUpcoming: false isUpcoming: false
title: "Frontend Performance" title: "Frontend Performance"

@ -70,7 +70,7 @@ if (roadmapFAQs.length) {
{ {
!roadmapData.isUpcoming && roadmapData.jsonUrl && ( !roadmapData.isUpcoming && roadmapData.jsonUrl && (
<div class='max-w-[1000px] container relative'> <div class='max-w-[1000px] container relative'>
<ShareIcons description={roadmapData.description} pageUrl={`https://roadmap.sh/${roadmapId}`} /> <ShareIcons description={roadmapData.featuredDescription} pageUrl={`https://roadmap.sh/${roadmapId}`} />
<FrameRenderer <FrameRenderer
roadmapId={roadmapId} roadmapId={roadmapId}

@ -63,7 +63,7 @@ if (bestPracticeData.schema) {
!bestPracticeData.isUpcoming && bestPracticeData.jsonUrl && ( !bestPracticeData.isUpcoming && bestPracticeData.jsonUrl && (
<div class='max-w-[1000px] container relative'> <div class='max-w-[1000px] container relative'>
<ShareIcons <ShareIcons
description={bestPracticeData.description} description={bestPracticeData.featuredDescription}
pageUrl={`https://roadmap.sh/best-practices/${bestPracticeId}`} pageUrl={`https://roadmap.sh/best-practices/${bestPracticeId}`}
/> />

Loading…
Cancel
Save