From 98f0ebde8b508907c9c9679752b9ee81aa210dad Mon Sep 17 00:00:00 2001 From: Kamran Ahmed Date: Wed, 26 Apr 2023 17:17:39 +0100 Subject: [PATCH] Add code-review best practices --- bin/best-practice-content.cjs | 173 + bin/roadmap-content.cjs | 3 +- package.json | 1 + public/jsons/best-practices/code-review.json | 5720 ++++++++++++++++- .../best-practices/code-review/code-review.md | 2 +- .../content/address-author-concerns.md | 1 + .../content/address-feedback-received.md | 1 + .../content/adequate-review-time.md | 1 + .../code-review/content/adhere-guidelines.md | 1 + .../content/architecture-understanding.md | 1 + .../content/author-feedback-welcomed.md | 1 + .../code-review/content/celebrate-success.md | 1 + .../code-review/content/change-functioning.md | 1 + .../code-review/content/changes-ready.md | 1 + .../code-review/content/clear-feedback.md | 1 + .../code-guide-best-practices-adherence.md | 1 + .../content/code-review-purpose.md | 1 + .../content/collaborate-reviewer-author.md | 1 + .../content/complex-tasks-breakage.md | 1 + .../content/conflict-resolution.md | 1 + .../content/consistency-everywhere.md | 1 + .../continuous-improvement-over-perfection.md | 1 + .../content/cross-functional-knowledge.md | 1 + .../code-review/content/definition-of-done.md | 1 + .../content/determine-review-level.md | 1 + .../content/document-new-feature.md | 1 + .../code-review/content/document-process.md | 1 + .../content/encourage-participation.md | 1 + .../code-review/content/failing-text-bug.md | 1 + .../code-review/content/follow-guidelines.md | 1 + .../code-review/content/impact-of-change.md | 1 + .../content/implement-changes-explanations.md | 1 + .../code-review/content/index.md | 1 + .../code-review/content/knowledge-sharing.md | 1 + .../code-review/content/learn-context-reqs.md | 1 + .../content/list-review-risks-issues.md | 1 + .../content/merge-approved-code.md | 1 + .../content/monitor-performance.md | 1 + .../code-review/content/monitor-reviews.md | 1 + .../code-review/content/nitpick-comments.md | 1 + .../code-review/content/no-one-way-process.md | 1 + .../content/note-questions-for-review.md | 1 + .../code-review/content/open-mind-author.md | 1 + .../code-review/content/open-mind-reviewer.md | 1 + .../content/pair-programming-reviews.md | 1 + .../content/positive-feedback-criticism.md | 1 + .../content/potential-issues-review.md | 1 + .../content/potential-issues-reviewer.md | 1 + .../code-review/content/prepare-list.md | 1 + .../content/prioritize-feedback.md | 1 + .../content/professional-feedback.md | 1 + .../content/proper-description-pr.md | 1 + .../content/quality-code-overall.md | 1 + .../content/re-run-tests-verify.md | 1 + .../content/recognition-rewards.md | 1 + .../content/resolve-conflicts-timely.md | 1 + .../code-review/content/review-docs-design.md | 1 + .../content/review-docs-updated.md | 1 + .../code-review/content/review-tests.md | 1 + .../content/review-updated-code.md | 1 + .../content/run-tests-ensure-passing.md | 1 + .../code-review/content/seek-feedback.md | 1 + .../content/seek-team-members-feedback.md | 1 + .../code-review/content/self-review.md | 1 + .../content/set-clear-expectations.md | 1 + .../short-term-long-term-considerations.md | 1 + .../content/style-guide-preferences.md | 1 + .../code-review/content/submit-re-review.md | 1 + .../content/team-wide-style-followed.md | 1 + .../code-review/content/tested-in-dev.md | 1 + .../content/trends-issues-finding.md | 1 + .../content/update-docs-changes.md | 1 + .../content/update-review-changes-docs.md | 1 + .../code-review/content/use-automation.md | 1 + .../content/verify-changes-addressed.md | 1 + .../content/write-automated-tests.md | 1 + 76 files changed, 5966 insertions(+), 4 deletions(-) create mode 100644 bin/best-practice-content.cjs create mode 100644 src/data/best-practices/code-review/content/address-author-concerns.md create mode 100644 src/data/best-practices/code-review/content/address-feedback-received.md create mode 100644 src/data/best-practices/code-review/content/adequate-review-time.md create mode 100644 src/data/best-practices/code-review/content/adhere-guidelines.md create mode 100644 src/data/best-practices/code-review/content/architecture-understanding.md create mode 100644 src/data/best-practices/code-review/content/author-feedback-welcomed.md create mode 100644 src/data/best-practices/code-review/content/celebrate-success.md create mode 100644 src/data/best-practices/code-review/content/change-functioning.md create mode 100644 src/data/best-practices/code-review/content/changes-ready.md create mode 100644 src/data/best-practices/code-review/content/clear-feedback.md create mode 100644 src/data/best-practices/code-review/content/code-guide-best-practices-adherence.md create mode 100644 src/data/best-practices/code-review/content/code-review-purpose.md create mode 100644 src/data/best-practices/code-review/content/collaborate-reviewer-author.md create mode 100644 src/data/best-practices/code-review/content/complex-tasks-breakage.md create mode 100644 src/data/best-practices/code-review/content/conflict-resolution.md create mode 100644 src/data/best-practices/code-review/content/consistency-everywhere.md create mode 100644 src/data/best-practices/code-review/content/continuous-improvement-over-perfection.md create mode 100644 src/data/best-practices/code-review/content/cross-functional-knowledge.md create mode 100644 src/data/best-practices/code-review/content/definition-of-done.md create mode 100644 src/data/best-practices/code-review/content/determine-review-level.md create mode 100644 src/data/best-practices/code-review/content/document-new-feature.md create mode 100644 src/data/best-practices/code-review/content/document-process.md create mode 100644 src/data/best-practices/code-review/content/encourage-participation.md create mode 100644 src/data/best-practices/code-review/content/failing-text-bug.md create mode 100644 src/data/best-practices/code-review/content/follow-guidelines.md create mode 100644 src/data/best-practices/code-review/content/impact-of-change.md create mode 100644 src/data/best-practices/code-review/content/implement-changes-explanations.md create mode 100644 src/data/best-practices/code-review/content/index.md create mode 100644 src/data/best-practices/code-review/content/knowledge-sharing.md create mode 100644 src/data/best-practices/code-review/content/learn-context-reqs.md create mode 100644 src/data/best-practices/code-review/content/list-review-risks-issues.md create mode 100644 src/data/best-practices/code-review/content/merge-approved-code.md create mode 100644 src/data/best-practices/code-review/content/monitor-performance.md create mode 100644 src/data/best-practices/code-review/content/monitor-reviews.md create mode 100644 src/data/best-practices/code-review/content/nitpick-comments.md create mode 100644 src/data/best-practices/code-review/content/no-one-way-process.md create mode 100644 src/data/best-practices/code-review/content/note-questions-for-review.md create mode 100644 src/data/best-practices/code-review/content/open-mind-author.md create mode 100644 src/data/best-practices/code-review/content/open-mind-reviewer.md create mode 100644 src/data/best-practices/code-review/content/pair-programming-reviews.md create mode 100644 src/data/best-practices/code-review/content/positive-feedback-criticism.md create mode 100644 src/data/best-practices/code-review/content/potential-issues-review.md create mode 100644 src/data/best-practices/code-review/content/potential-issues-reviewer.md create mode 100644 src/data/best-practices/code-review/content/prepare-list.md create mode 100644 src/data/best-practices/code-review/content/prioritize-feedback.md create mode 100644 src/data/best-practices/code-review/content/professional-feedback.md create mode 100644 src/data/best-practices/code-review/content/proper-description-pr.md create mode 100644 src/data/best-practices/code-review/content/quality-code-overall.md create mode 100644 src/data/best-practices/code-review/content/re-run-tests-verify.md create mode 100644 src/data/best-practices/code-review/content/recognition-rewards.md create mode 100644 src/data/best-practices/code-review/content/resolve-conflicts-timely.md create mode 100644 src/data/best-practices/code-review/content/review-docs-design.md create mode 100644 src/data/best-practices/code-review/content/review-docs-updated.md create mode 100644 src/data/best-practices/code-review/content/review-tests.md create mode 100644 src/data/best-practices/code-review/content/review-updated-code.md create mode 100644 src/data/best-practices/code-review/content/run-tests-ensure-passing.md create mode 100644 src/data/best-practices/code-review/content/seek-feedback.md create mode 100644 src/data/best-practices/code-review/content/seek-team-members-feedback.md create mode 100644 src/data/best-practices/code-review/content/self-review.md create mode 100644 src/data/best-practices/code-review/content/set-clear-expectations.md create mode 100644 src/data/best-practices/code-review/content/short-term-long-term-considerations.md create mode 100644 src/data/best-practices/code-review/content/style-guide-preferences.md create mode 100644 src/data/best-practices/code-review/content/submit-re-review.md create mode 100644 src/data/best-practices/code-review/content/team-wide-style-followed.md create mode 100644 src/data/best-practices/code-review/content/tested-in-dev.md create mode 100644 src/data/best-practices/code-review/content/trends-issues-finding.md create mode 100644 src/data/best-practices/code-review/content/update-docs-changes.md create mode 100644 src/data/best-practices/code-review/content/update-review-changes-docs.md create mode 100644 src/data/best-practices/code-review/content/use-automation.md create mode 100644 src/data/best-practices/code-review/content/verify-changes-addressed.md create mode 100644 src/data/best-practices/code-review/content/write-automated-tests.md diff --git a/bin/best-practice-content.cjs b/bin/best-practice-content.cjs new file mode 100644 index 000000000..0c6fed280 --- /dev/null +++ b/bin/best-practice-content.cjs @@ -0,0 +1,173 @@ +const fs = require('fs'); +const path = require('path'); + +const OPEN_AI_API_KEY = process.env.OPEN_AI_API_KEY; +const ALL_BEST_PRACTICES_DIR = path.join( + __dirname, + '../src/data/best-practices' +); +const BEST_PRACTICE_JSON_DIR = path.join( + __dirname, + '../public/jsons/best-practices' +); + +const bestPracticeId = process.argv[2]; +const bestPracticeTitle = bestPracticeId.replace(/-/g, ' '); + +const allowedBestPracticeIds = fs.readdirSync(ALL_BEST_PRACTICES_DIR); +if (!bestPracticeId) { + console.error('bestPracticeId is required'); + process.exit(1); +} + +if (!allowedBestPracticeIds.includes(bestPracticeId)) { + console.error(`Invalid bestPractice key ${bestPracticeId}`); + console.error(`Allowed keys are ${allowedBestPracticeIds.join(', ')}`); + process.exit(1); +} + +const BEST_PRACTICE_CONTENT_DIR = path.join( + ALL_BEST_PRACTICES_DIR, + bestPracticeId, + 'content' +); +const { Configuration, OpenAIApi } = require('openai'); +const configuration = new Configuration({ + apiKey: OPEN_AI_API_KEY, +}); + +const openai = new OpenAIApi(configuration); + +function getFilesInFolder(folderPath, fileList = {}) { + const files = fs.readdirSync(folderPath); + + files.forEach((file) => { + const filePath = path.join(folderPath, file); + const stats = fs.statSync(filePath); + + if (stats.isDirectory()) { + getFilesInFolder(filePath, fileList); + } else if (stats.isFile()) { + const fileUrl = filePath + .replace(BEST_PRACTICE_CONTENT_DIR, '') // Remove the content folder + .replace(/\/\d+-/g, '/') // Remove ordering info `/101-ecosystem` + .replace(/\/index\.md$/, '') // Make the `/index.md` to become the parent folder only + .replace(/\.md$/, ''); // Remove `.md` from the end of file + + fileList[fileUrl] = filePath; + } + }); + + return fileList; +} + +function writeTopicContent(topicTitle) { + let prompt = `I am reading best-practices about "${bestPracticeTitle}". I want to know more about "${parentTopic}". Why is it important? Content should be in markdown. Behave as if you are the author of the best practices.`; + + console.log(`Generating '${topicTitle || parentTopic}'...`); + + return new Promise((resolve, reject) => { + openai + .createChatCompletion({ + model: 'gpt-4', + messages: [ + { + role: 'user', + content: prompt, + }, + ], + }) + .then((response) => { + const article = response.data.choices[0].message.content; + + resolve(article); + }) + .catch((err) => { + reject(err); + }); + }); +} + +async function writeFileForGroup(group, topicUrlToPathMapping) { + const topicId = group?.properties?.controlName; + const topicTitle = group?.children?.controls?.control?.find( + (control) => control?.typeID === 'Label' + )?.properties?.text; + const currTopicUrl = `/${topicId}`; + if (currTopicUrl.startsWith('/check:')) { + return; + } + + const contentFilePath = topicUrlToPathMapping[currTopicUrl]; + + if (!contentFilePath) { + console.log(`Missing file for: ${currTopicUrl}`); + process.exit(0); + return; + } + + const currentFileContent = fs.readFileSync(contentFilePath, 'utf8'); + const isFileEmpty = currentFileContent.replace(/^#.+/, ``).trim() === ''; + + if (!isFileEmpty) { + console.log(`Ignoring ${topicId}. Not empty.`); + return; + } + + let newFileContent = `# ${topicTitle}`; + + if (!OPEN_AI_API_KEY) { + console.log(`Writing ${topicId}..`); + + fs.writeFileSync(contentFilePath, newFileContent, 'utf8'); + return; + } + + const topicContent = await writeTopicContent(topicTitle); + newFileContent += `\n\n${topicContent}`; + + console.log(`Writing ${topicId}..`); + fs.writeFileSync(contentFilePath, newFileContent, 'utf8'); + + // console.log(currentFileContent); + // console.log(currTopicUrl); + // console.log(topicTitle); + // console.log(topicUrlToPathMapping[currTopicUrl]); +} + +async function run() { + const topicUrlToPathMapping = getFilesInFolder(BEST_PRACTICE_CONTENT_DIR); + + const bestPracticeJson = require(path.join( + BEST_PRACTICE_JSON_DIR, + `${bestPracticeId}.json` + )); + const groups = bestPracticeJson?.mockup?.controls?.control?.filter( + (control) => + control.typeID === '__group__' && + !control.properties?.controlName?.startsWith('ext_link') + ); + + if (!OPEN_AI_API_KEY) { + console.log('----------------------------------------'); + console.log('OPEN_AI_API_KEY not found. Skipping openai api calls...'); + console.log('----------------------------------------'); + } + + const writePromises = []; + for (let group of groups) { + writePromises.push(writeFileForGroup(group, topicUrlToPathMapping)); + } + + console.log('Waiting for all files to be written...'); + await Promise.all(writePromises); +} + +run() + .then(() => { + console.log('Done'); + }) + .catch((err) => { + console.error(err); + process.exit(1); + }); diff --git a/bin/roadmap-content.cjs b/bin/roadmap-content.cjs index c08120114..04ebe2f99 100644 --- a/bin/roadmap-content.cjs +++ b/bin/roadmap-content.cjs @@ -59,8 +59,7 @@ function writeTopicContent(currTopicUrl) { .slice(-2) .map((topic) => topic.replace(/-/g, ' ')); - // const roadmapTitle = roadmapId.replace(/-/g, ' '); - const roadmapTitle = 'PostgreSQL'; + const roadmapTitle = roadmapId.replace(/-/g, ' '); let prompt = `I am reading a guide about "${roadmapTitle}". I am on the topic "${parentTopic}". I want to know more about "${childTopic}". Write me a brief summary for that topic. Content should be in markdown. Behave as if you are the author of the guide.`; if (!childTopic) { diff --git a/package.json b/package.json index 6d6bd7089..044f926c4 100644 --- a/package.json +++ b/package.json @@ -17,6 +17,7 @@ "roadmap-dirs": "node bin/roadmap-dirs.cjs", "roadmap-content": "node bin/roadmap-content.cjs", "best-practice-dirs": "node bin/best-practice-dirs.cjs", + "best-practice-content": "node bin/best-practice-content.cjs", "test:e2e": "playwright test" }, "dependencies": { diff --git a/public/jsons/best-practices/code-review.json b/public/jsons/best-practices/code-review.json index 935eb44db..5fd68520b 100644 --- a/public/jsons/best-practices/code-review.json +++ b/public/jsons/best-practices/code-review.json @@ -1 +1,5719 @@ -{"mockup":{"controls":{"control":[{"ID":"2466","typeID":"Arrow","zOrder":"0","w":"1","h":"81","measuredW":"150","measuredH":"100","x":"859","y":"4600","properties":{"curvature":"0","leftArrow":"false","rightArrow":"false","stroke":"dotted","color":"10027263","p0":{"x":0,"y":0},"p1":{"x":0.49999999999999994,"y":0},"p2":{"x":0,"y":81.09090909090901}}},{"ID":"2471","typeID":"Arrow","zOrder":"1","w":"1234","h":"1","measuredW":"150","measuredH":"100","x":"239","y":"413","properties":{"curvature":"0","leftArrow":"false","rightArrow":"false","color":"4273622","p0":{"x":-0.3879633062732637,"y":0},"p1":{"x":0.4999449522687742,"y":0.0003335799224988863},"p2":{"x":1233.8055670724293,"y":0}}},{"ID":"2472","typeID":"Canvas","zOrder":"45","w":"293","h":"50","measuredW":"100","measuredH":"70","x":"407","y":"387","properties":{"color":"16776960"}},{"ID":"2475","typeID":"Label","zOrder":"4","measuredW":"260","measuredH":"48","x":"730","y":"227","properties":{"text":"Code Reviews","size":"40"}},{"ID":"2476","typeID":"Canvas","zOrder":"5","w":"361","h":"150","measuredW":"100","measuredH":"70","x":"1116","y":"188"},{"ID":"2477","typeID":"Label","zOrder":"6","measuredW":"332","measuredH":"26","x":"1132","y":"206","properties":{"text":"Find the detailed version of this checklist","size":"18"}},{"ID":"2478","typeID":"Label","zOrder":"7","measuredW":"318","measuredH":"26","x":"1132","y":"234","properties":{"size":"18","text":"With details on how to implement these"}},{"ID":"2479","typeID":"__group__","zOrder":"8","measuredW":"329","measuredH":"51","w":"329","h":"51","x":"1132","y":"270","properties":{"controlName":"ext_link:roadmap.sh"},"children":{"controls":{"control":[{"ID":"0","typeID":"Canvas","zOrder":"0","w":"329","h":"51","measuredW":"100","measuredH":"70","x":"0","y":"0","properties":{"color":"4273622","borderColor":"4273622"}},{"ID":"1","typeID":"Label","zOrder":"1","measuredW":"172","measuredH":"28","x":"79","y":"12","properties":{"color":"16777215","size":"20","text":"https://roadmap.sh"}}]}}},{"ID":"2480","typeID":"Canvas","zOrder":"9","w":"373","h":"169","measuredW":"100","measuredH":"70","x":"225","y":"168"},{"ID":"2481","typeID":"__group__","zOrder":"10","measuredW":"160","measuredH":"27","w":"160","h":"27","x":"255","y":"242","properties":{"controlName":"ext_link:roadmap.sh/roadmaps"},"children":{"controls":{"control":[{"ID":"0","typeID":"Label","zOrder":"0","measuredW":"127","measuredH":"26","x":"33","y":"0","properties":{"size":"18","text":"Visit Roadmaps"}},{"ID":"1","typeID":"__group__","zOrder":"1","measuredW":"24","measuredH":"24","w":"24","h":"24","x":"0","y":"3","children":{"controls":{"control":[{"ID":"0","typeID":"Icon","zOrder":"0","measuredW":"24","measuredH":"24","x":"0","y":"0","properties":{"color":"16777215","icon":{"ID":"circle","size":"small"}}},{"ID":"1","typeID":"Icon","zOrder":"1","measuredW":"24","measuredH":"24","x":"0","y":"0","properties":{"color":"10066329","icon":{"ID":"check-circle","size":"small"}}}]}}}]}}},{"ID":"2482","typeID":"__group__","zOrder":"11","measuredW":"203","measuredH":"27","w":"203","h":"27","x":"255","y":"278","properties":{"controlName":"ext_link:roadmap.sh/best-practices"},"children":{"controls":{"control":[{"ID":"0","typeID":"Label","zOrder":"0","measuredW":"170","measuredH":"26","x":"33","y":"0","properties":{"size":"18","text":"Other Best Practices"}},{"ID":"1","typeID":"__group__","zOrder":"1","measuredW":"24","measuredH":"24","w":"24","h":"24","x":"0","y":"3","children":{"controls":{"control":[{"ID":"0","typeID":"Icon","zOrder":"0","measuredW":"24","measuredH":"24","x":"0","y":"0","properties":{"color":"16777215","icon":{"ID":"circle","size":"small"}}},{"ID":"1","typeID":"Icon","zOrder":"1","measuredW":"24","measuredH":"24","x":"0","y":"0","properties":{"color":"10066329","icon":{"ID":"check-circle","size":"small"}}}]}}}]}}},{"ID":"2483","typeID":"Label","zOrder":"12","measuredW":"150","measuredH":"32","x":"255","y":"192","properties":{"size":"24","text":"More Content"}},{"ID":"2484","typeID":"Arrow","zOrder":"13","w":"1","h":"76","measuredW":"150","measuredH":"100","x":"859","y":"135","properties":{"curvature":"0","leftArrow":"false","rightArrow":"false","p0":{"x":0,"y":0},"p1":{"x":0.49999999999999994,"y":0},"p2":{"x":0,"y":76.17275043077757},"stroke":"dotted","color":"10027263"}},{"ID":"2563","typeID":"Label","zOrder":"46","measuredW":"190","measuredH":"28","x":"459","y":"398","properties":{"size":"20","text":"Team Wide Practices"}},{"ID":"2564","typeID":"Arrow","zOrder":"14","w":"1","h":"123","measuredW":"150","measuredH":"100","x":"859","y":"288","properties":{"curvature":"0","leftArrow":"false","rightArrow":"false","color":"4273622","p0":{"x":0,"y":-0.48484848484849863},"p1":{"x":0.5,"y":0},"p2":{"x":0,"y":122.37977858123031}}},{"ID":"2586","typeID":"Label","zOrder":"3","measuredW":"474","measuredH":"28","x":"344","y":"484","properties":{"text":"Document and standardize the code review process.","size":"20"}},{"ID":"2587","typeID":"TextArea","zOrder":"2","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"483"},{"ID":"2624","typeID":"TextArea","zOrder":"15","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"525"},{"ID":"2625","typeID":"Label","zOrder":"16","measuredW":"552","measuredH":"28","x":"344","y":"526","properties":{"text":"Ensure that the purpose of code reviews is clear to everyone.","size":"20"}},{"ID":"2626","typeID":"TextArea","zOrder":"17","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"652"},{"ID":"2627","typeID":"Label","zOrder":"18","measuredW":"496","measuredH":"28","x":"344","y":"653","properties":{"text":"Define a process for conflict resolution in code reviews.","size":"20"}},{"ID":"2628","typeID":"TextArea","zOrder":"19","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"692"},{"ID":"2629","typeID":"Label","zOrder":"20","measuredW":"448","measuredH":"28","x":"344","y":"693","properties":{"text":"Have a definitive style guide for style preferences.","size":"20"}},{"ID":"2630","typeID":"TextArea","zOrder":"21","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"734"},{"ID":"2631","typeID":"Label","zOrder":"22","measuredW":"595","measuredH":"28","x":"345","y":"735","properties":{"text":"Use automation to speed up the code reviews (linting, sniffing etc)","size":"20"}},{"ID":"2632","typeID":"TextArea","zOrder":"23","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"775"},{"ID":"2633","typeID":"Label","zOrder":"24","measuredW":"509","measuredH":"28","x":"345","y":"776","properties":{"text":"Set clear expectations for code review turnaround times.","size":"20"}},{"ID":"2634","typeID":"TextArea","zOrder":"25","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"816"},{"ID":"2635","typeID":"Label","zOrder":"26","measuredW":"629","measuredH":"28","x":"346","y":"817","properties":{"text":"Provide adequate time for code reviews and ensure that it is a priority.","size":"20"}},{"ID":"2636","typeID":"TextArea","zOrder":"27","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"857"},{"ID":"2637","typeID":"Label","zOrder":"28","measuredW":"648","measuredH":"28","x":"346","y":"858","properties":{"text":"Use code reviews as an opportunity for knowledge sharing and learning.","size":"20"}},{"ID":"2638","typeID":"TextArea","zOrder":"29","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"940"},{"ID":"2639","typeID":"Label","zOrder":"30","measuredW":"481","measuredH":"28","x":"346","y":"941","properties":{"text":"Constantly monitor and improve code review process.","size":"20"}},{"ID":"2640","typeID":"TextArea","zOrder":"31","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"980"},{"ID":"2641","typeID":"Label","zOrder":"32","measuredW":"645","measuredH":"28","x":"347","y":"981","properties":{"text":"Recognition and rewards for those with track record of quality feedback.","size":"20"}},{"ID":"2642","typeID":"TextArea","zOrder":"33","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"610"},{"ID":"2643","typeID":"Label","zOrder":"34","measuredW":"516","measuredH":"28","x":"344","y":"611","properties":{"text":"Encourage team members to participate in code reviews.","size":"20"}},{"ID":"2644","typeID":"TextArea","zOrder":"35","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"898"},{"ID":"2645","typeID":"Label","zOrder":"36","measuredW":"690","measuredH":"28","x":"346","y":"899","properties":{"text":"Encourage reviewing code in unknown-areas for cross-functional knowledge.","size":"20"}},{"ID":"2646","typeID":"TextArea","zOrder":"37","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"565"},{"ID":"2647","typeID":"Label","zOrder":"38","measuredW":"630","measuredH":"28","x":"344","y":"566","properties":{"text":"Ensure that “Definition of Done” is documented and clear to everyone","size":"20"}},{"ID":"2648","typeID":"TextArea","zOrder":"39","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"1022"},{"ID":"2649","typeID":"Label","zOrder":"40","measuredW":"828","measuredH":"28","x":"347","y":"1023","properties":{"text":"Encourage communication/collaboration; avoid treating code reviews as a one-way process.","size":"20"}},{"ID":"2650","typeID":"TextArea","zOrder":"41","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"1063"},{"ID":"2651","typeID":"Label","zOrder":"42","measuredW":"965","measuredH":"28","x":"347","y":"1064","properties":{"size":"20","text":"Hold regular code review sessions to discuss broader trends or issues that arise during the review process."}},{"ID":"2652","typeID":"TextArea","zOrder":"43","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"1107"},{"ID":"2653","typeID":"Label","zOrder":"44","measuredW":"878","measuredH":"28","x":"347","y":"1108","properties":{"size":"20","text":"Encourage authors to seek feedback during development before submitting a formal code review."}},{"ID":"2655","typeID":"Arrow","zOrder":"47","w":"1","h":"793","measuredW":"150","measuredH":"100","x":"237","y":"413","properties":{"curvature":"0","leftArrow":"false","rightArrow":"false","color":"4273622","p0":{"x":0,"y":-0.48484848484849863},"p1":{"x":0.5,"y":0},"p2":{"x":0,"y":792.1520096524373}}},{"ID":"2656","typeID":"Arrow","zOrder":"48","w":"1224","h":"1","measuredW":"150","measuredH":"100","x":"239","y":"1206","properties":{"curvature":"0","leftArrow":"false","rightArrow":"false","color":"4273622","p0":{"x":0,"y":0},"p1":{"x":0.4998545777165489,"y":0.00028245338618605997},"p2":{"x":1223,"y":0}}},{"ID":"2657","typeID":"Canvas","zOrder":"49","w":"355","h":"50","measuredW":"100","measuredH":"70","x":"389","y":"1182","properties":{"color":"16776960"}},{"ID":"2658","typeID":"Label","zOrder":"50","measuredW":"266","measuredH":"28","x":"434","y":"1193","properties":{"size":"20","text":"During Development (Author)"}},{"ID":"2659","typeID":"TextArea","zOrder":"51","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"1281"},{"ID":"2660","typeID":"Label","zOrder":"52","measuredW":"533","measuredH":"28","x":"344","y":"1282","properties":{"size":"20","text":"Follow the coding standards and any other team guidelines."}},{"ID":"2661","typeID":"TextArea","zOrder":"53","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"1323"},{"ID":"2662","typeID":"Label","zOrder":"54","measuredW":"567","measuredH":"28","x":"344","y":"1324","properties":{"size":"20","text":"Stay consistent with the overall project design and architecture."}},{"ID":"2663","typeID":"TextArea","zOrder":"55","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"1363"},{"ID":"2664","typeID":"Label","zOrder":"56","measuredW":"421","measuredH":"28","x":"344","y":"1364","properties":{"size":"20","text":"Write a failing test if the change is for a bug fix."}},{"ID":"2665","typeID":"TextArea","zOrder":"57","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"1404"},{"ID":"2666","typeID":"Label","zOrder":"58","measuredW":"569","measuredH":"28","x":"344","y":"1405","properties":{"size":"20","text":"Break down complex tasks into smaller easily manageable PRs."}},{"ID":"2667","typeID":"TextArea","zOrder":"59","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"1447"},{"ID":"2668","typeID":"Label","zOrder":"60","measuredW":"576","measuredH":"28","x":"344","y":"1448","properties":{"size":"20","text":"Consider the impact of the change on other parts of the system."}},{"ID":"2669","typeID":"TextArea","zOrder":"61","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"1490"},{"ID":"2670","typeID":"Label","zOrder":"62","measuredW":"844","measuredH":"28","x":"344","y":"1491","properties":{"size":"20","text":"Take notes on any questions or concerns about the change to discuss them during the review."}},{"ID":"2671","typeID":"TextArea","zOrder":"63","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"1531"},{"ID":"2672","typeID":"Label","zOrder":"64","measuredW":"238","measuredH":"28","x":"344","y":"1532","properties":{"size":"20","text":"Write the automated tests."}},{"ID":"2673","typeID":"TextArea","zOrder":"65","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"1570"},{"ID":"2674","typeID":"Label","zOrder":"66","measuredW":"566","measuredH":"28","x":"344","y":"1572","properties":{"size":"20","text":"Write the documentation for the feature or changes if required."}},{"ID":"2675","typeID":"TextArea","zOrder":"67","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"1610"},{"ID":"2676","typeID":"Label","zOrder":"68","measuredW":"709","measuredH":"28","x":"344","y":"1611","properties":{"size":"20","text":"Update any documentation that may have made obsolete through the changes."}},{"ID":"2677","typeID":"Arrow","zOrder":"69","w":"1","h":"926","measuredW":"150","measuredH":"100","x":"1462","y":"1207","properties":{"curvature":"0","leftArrow":"false","rightArrow":"false","color":"4273622","p0":{"x":0,"y":-0.48484848484849863},"p1":{"x":0.5,"y":0},"p2":{"x":0,"y":925.3476519188584}}},{"ID":"2678","typeID":"Arrow","zOrder":"70","w":"1236","h":"1","measuredW":"150","measuredH":"100","x":"225","y":"1714","properties":{"curvature":"0","leftArrow":"false","rightArrow":"false","color":"4273622","p0":{"x":0,"y":0},"p1":{"x":0.4999101217590421,"y":0.0002824717439428831},"p2":{"x":1235,"y":0}}},{"ID":"2679","typeID":"Canvas","zOrder":"71","w":"355","h":"50","measuredW":"100","measuredH":"70","x":"376","y":"1690","properties":{"color":"16776960"}},{"ID":"2680","typeID":"Label","zOrder":"72","measuredW":"283","measuredH":"28","x":"412","y":"1701","properties":{"size":"20","text":"After the Development (Author)"}},{"ID":"2681","typeID":"TextArea","zOrder":"73","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"297","y":"1781"},{"ID":"2682","typeID":"Label","zOrder":"74","measuredW":"418","measuredH":"28","x":"343","y":"1782","properties":{"size":"20","text":"Review your code before submitting for review."}},{"ID":"2683","typeID":"TextArea","zOrder":"75","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"297","y":"1823"},{"ID":"2684","typeID":"Label","zOrder":"76","measuredW":"979","measuredH":"28","x":"343","y":"1824","properties":{"size":"20","text":"Ensure that the changes are complete and ready for review, including all necessary tests and documentation."}},{"ID":"2685","typeID":"TextArea","zOrder":"77","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"297","y":"1865"},{"ID":"2686","typeID":"Label","zOrder":"78","measuredW":"760","measuredH":"28","x":"343","y":"1866","properties":{"size":"20","text":"Verify that the code change has been properly tested in a development environment."}},{"ID":"2687","typeID":"TextArea","zOrder":"79","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"1906"},{"ID":"2688","typeID":"Label","zOrder":"80","measuredW":"813","measuredH":"28","x":"344","y":"1907","properties":{"size":"20","text":"Double-check that the code adheres to the project's coding standards and best practices. "}},{"ID":"2689","typeID":"TextArea","zOrder":"81","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"1949"},{"ID":"2690","typeID":"Label","zOrder":"82","measuredW":"1023","measuredH":"28","x":"344","y":"1950","properties":{"size":"20","text":"Identify any potential performance, security, or scalability concerns and note them for discussion during the review."}},{"ID":"2691","typeID":"TextArea","zOrder":"83","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"1990"},{"ID":"2692","typeID":"Label","zOrder":"84","measuredW":"989","measuredH":"28","x":"344","y":"1991","properties":{"size":"20","text":"Make sure to add proper title, description, any screenshots, relevant links, configuration changes etc in the PR."}},{"ID":"2693","typeID":"TextArea","zOrder":"85","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"2032"},{"ID":"2694","typeID":"Label","zOrder":"86","measuredW":"1069","measuredH":"28","x":"344","y":"2033","properties":{"size":"20","text":"Approach the review process with an open mind, and be willing to learn from and collaborate with other team members."}},{"ID":"2695","typeID":"Arrow","zOrder":"87","w":"1236","h":"1","measuredW":"150","measuredH":"100","x":"225","y":"2133","properties":{"curvature":"0","leftArrow":"false","rightArrow":"false","color":"4273622","p0":{"x":0,"y":0},"p1":{"x":0.4999101217590421,"y":0.0002824717439428831},"p2":{"x":1235,"y":0}}},{"ID":"2696","typeID":"Canvas","zOrder":"88","w":"355","h":"50","measuredW":"100","measuredH":"70","x":"372","y":"2108","properties":{"color":"16776960"}},{"ID":"2697","typeID":"Label","zOrder":"89","measuredW":"264","measuredH":"28","x":"408","y":"2119","properties":{"size":"20","text":"Before Reviewing (Reviewer)"}},{"ID":"2698","typeID":"TextArea","zOrder":"90","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"2202"},{"ID":"2699","typeID":"Label","zOrder":"91","measuredW":"663","measuredH":"28","x":"344","y":"2203","properties":{"size":"20","text":"Understand the requirements and the context in which change was made."}},{"ID":"2700","typeID":"TextArea","zOrder":"92","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"2242"},{"ID":"2701","typeID":"Label","zOrder":"93","measuredW":"879","measuredH":"28","x":"344","y":"2243","properties":{"size":"20","text":"Based on the requirements, prepare a list of items that should have been covered in the changes."}},{"ID":"2702","typeID":"TextArea","zOrder":"94","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"2281"},{"ID":"2703","typeID":"Label","zOrder":"95","measuredW":"561","measuredH":"28","x":"344","y":"2282","properties":{"size":"20","text":"Ensure that you understand the codebase and its architecture."}},{"ID":"2704","typeID":"TextArea","zOrder":"96","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"2322"},{"ID":"2705","typeID":"Label","zOrder":"97","measuredW":"664","measuredH":"28","x":"344","y":"2323","properties":{"size":"20","text":"Review any documentation or design specifications related to the change."}},{"ID":"2706","typeID":"TextArea","zOrder":"98","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"2361"},{"ID":"2707","typeID":"Label","zOrder":"99","measuredW":"653","measuredH":"28","x":"344","y":"2362","properties":{"size":"20","text":"Make list of any potential risks or issues that could arise with the change."}},{"ID":"2708","typeID":"TextArea","zOrder":"100","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"2401"},{"ID":"2709","typeID":"Label","zOrder":"101","measuredW":"1121","measuredH":"28","x":"344","y":"2402","properties":{"size":"20","text":"Approach the process with an open mind; be willing to provide constructive feedback and collaborate to improve code quality"}},{"ID":"2710","typeID":"TextArea","zOrder":"102","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"2442"},{"ID":"2711","typeID":"Label","zOrder":"103","measuredW":"813","measuredH":"28","x":"344","y":"2443","properties":{"size":"20","text":"Consider the overall quality of the code, including readability, maintainability, and scalability."}},{"ID":"2712","typeID":"TextArea","zOrder":"104","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"2482"},{"ID":"2713","typeID":"Label","zOrder":"105","measuredW":"925","measuredH":"28","x":"344","y":"2483","properties":{"size":"20","text":"Determine the appropriate level of review needed based on the scope and impact of the code change."}},{"ID":"2714","typeID":"Arrow","zOrder":"106","w":"1","h":"1130","measuredW":"150","measuredH":"100","x":"225","y":"2134","properties":{"curvature":"0","leftArrow":"false","rightArrow":"false","color":"4273622","p0":{"x":0,"y":-0.48484848484849863},"p1":{"x":0.5,"y":0},"p2":{"x":0,"y":1129.6419329625296}}},{"ID":"2719","typeID":"Arrow","zOrder":"107","w":"1236","h":"1","measuredW":"150","measuredH":"100","x":"225","y":"2616","properties":{"curvature":"0","leftArrow":"false","rightArrow":"false","color":"4273622","p0":{"x":0,"y":0},"p1":{"x":0.4999101217590421,"y":0.0002824717439428831},"p2":{"x":1235,"y":0}}},{"ID":"2720","typeID":"Canvas","zOrder":"108","w":"355","h":"50","measuredW":"100","measuredH":"70","x":"372","y":"2591","properties":{"color":"16776960"}},{"ID":"2721","typeID":"Label","zOrder":"109","measuredW":"291","measuredH":"28","x":"404","y":"2602","properties":{"size":"20","text":"During Code Review (Reviewer)"}},{"ID":"2722","typeID":"TextArea","zOrder":"110","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"2687"},{"ID":"2723","typeID":"Label","zOrder":"111","measuredW":"900","measuredH":"28","x":"344","y":"2688","properties":{"size":"20","text":"Be respectful and professional in your feedback, avoiding personal attacks or derogatory comments."}},{"ID":"2724","typeID":"TextArea","zOrder":"112","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"2526"},{"ID":"2725","typeID":"Label","zOrder":"113","measuredW":"992","measuredH":"28","x":"344","y":"2527","properties":{"size":"20","text":"Be willing to collaborate with the author to resolve any issues or concerns that arise during the review process."}},{"ID":"2726","typeID":"TextArea","zOrder":"114","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"2728"},{"ID":"2727","typeID":"Label","zOrder":"115","measuredW":"1091","measuredH":"28","x":"344","y":"2729","properties":{"size":"20","text":"Provide clear and actionable feedback, including specific suggestions for improvement and explanations of any concerns."}},{"ID":"2728","typeID":"TextArea","zOrder":"116","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"2767"},{"ID":"2729","typeID":"Label","zOrder":"117","measuredW":"902","measuredH":"28","x":"344","y":"2768","properties":{"size":"20","text":"Identify any potential performance, security, or scalability concerns, and discuss them with the author."}},{"ID":"2730","typeID":"TextArea","zOrder":"118","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"2807"},{"ID":"2731","typeID":"Label","zOrder":"119","measuredW":"606","measuredH":"28","x":"344","y":"2808","properties":{"size":"20","text":"Prioritize your feedback, focusing on the most important issues first."}},{"ID":"2732","typeID":"TextArea","zOrder":"120","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"2847"},{"ID":"2733","typeID":"Label","zOrder":"121","measuredW":"1051","measuredH":"28","x":"344","y":"2848","properties":{"size":"20","text":"Review any tests included with the code change to verify that they adequately cover the functionality and edge cases."}},{"ID":"2734","typeID":"TextArea","zOrder":"122","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"2887"},{"ID":"2735","typeID":"Label","zOrder":"123","measuredW":"819","measuredH":"28","x":"344","y":"2888","properties":{"size":"20","text":"Ensure that the code change adheres to the project's coding standards and best practices."}},{"ID":"2736","typeID":"TextArea","zOrder":"124","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"2926"},{"ID":"2737","typeID":"Label","zOrder":"125","measuredW":"531","measuredH":"28","x":"344","y":"2927","properties":{"size":"20","text":"Ensure that the relevant documentation has been updated."}},{"ID":"2738","typeID":"TextArea","zOrder":"126","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"2966"},{"ID":"2739","typeID":"Label","zOrder":"127","measuredW":"594","measuredH":"28","x":"344","y":"2967","properties":{"size":"20","text":"Team wide style guide is the absolute authority on matters of style."}},{"ID":"2740","typeID":"TextArea","zOrder":"128","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"3006"},{"ID":"2741","typeID":"Label","zOrder":"129","measuredW":"960","measuredH":"28","x":"344","y":"3007","properties":{"size":"20","text":"Leave comments to suggest improvements, but prefix it with \"Nit\" if it's not critical to meeting the standards"}},{"ID":"2742","typeID":"TextArea","zOrder":"130","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"3048"},{"ID":"2743","typeID":"Label","zOrder":"131","measuredW":"413","measuredH":"28","x":"344","y":"3049","properties":{"size":"20","text":"Seek continuous improvement, not perfection."}},{"ID":"2744","typeID":"TextArea","zOrder":"132","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"3088"},{"ID":"2745","typeID":"Label","zOrder":"133","measuredW":"528","measuredH":"28","x":"344","y":"3089","properties":{"size":"20","text":"Keep the short-term and long-term considerations in mind."}},{"ID":"2746","typeID":"TextArea","zOrder":"134","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"3128"},{"ID":"2747","typeID":"Label","zOrder":"135","measuredW":"743","measuredH":"28","x":"344","y":"3129","properties":{"size":"20","text":"Consider using pair programming as an alternative or supplement to code reviews."}},{"ID":"2748","typeID":"TextArea","zOrder":"136","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"3168"},{"ID":"2749","typeID":"Label","zOrder":"137","measuredW":"1019","measuredH":"28","x":"344","y":"3169","properties":{"size":"20","text":"Provide positive feedback in addition to constructive criticism, to reinforce good practices and boost team morale."}},{"ID":"2753","typeID":"Arrow","zOrder":"138","w":"1236","h":"1","measuredW":"150","measuredH":"100","x":"225","y":"3265","properties":{"curvature":"0","leftArrow":"false","rightArrow":"false","color":"4273622","p0":{"x":0,"y":0},"p1":{"x":0.4999101217590421,"y":0.0002824717439428831},"p2":{"x":1235,"y":0}}},{"ID":"2754","typeID":"Canvas","zOrder":"139","w":"355","h":"50","measuredW":"100","measuredH":"70","x":"348","y":"3239","properties":{"color":"16776960"}},{"ID":"2755","typeID":"Label","zOrder":"140","measuredW":"283","measuredH":"28","x":"384","y":"3250","properties":{"size":"20","text":"After the Code Review (Author)"}},{"ID":"2756","typeID":"TextArea","zOrder":"141","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"3340"},{"ID":"2757","typeID":"Label","zOrder":"142","measuredW":"704","measuredH":"28","x":"344","y":"3341","properties":{"size":"20","text":"Address all the feedback received, including any concerns or questions raised."}},{"ID":"2758","typeID":"TextArea","zOrder":"143","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"3380"},{"ID":"2759","typeID":"Label","zOrder":"144","measuredW":"686","measuredH":"28","x":"344","y":"3381","properties":{"size":"20","text":"Implement the suggested changes and provide explanations where needed."}},{"ID":"2760","typeID":"TextArea","zOrder":"145","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"3421"},{"ID":"2761","typeID":"Label","zOrder":"146","measuredW":"586","measuredH":"28","x":"344","y":"3422","properties":{"size":"20","text":"Run the tests and ensure that they all pass after making changes"}},{"ID":"2762","typeID":"TextArea","zOrder":"147","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"3461"},{"ID":"2763","typeID":"Label","zOrder":"148","measuredW":"642","measuredH":"28","x":"344","y":"3462","properties":{"size":"20","text":"Update any documentation or code comments affected by the changes."}},{"ID":"2764","typeID":"TextArea","zOrder":"149","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"3502"},{"ID":"2765","typeID":"Label","zOrder":"150","measuredW":"709","measuredH":"28","x":"344","y":"3503","properties":{"size":"20","text":"Seek feedback from other team members if you are unsure about the changes."}},{"ID":"2766","typeID":"TextArea","zOrder":"151","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"3545"},{"ID":"2767","typeID":"Label","zOrder":"152","measuredW":"505","measuredH":"28","x":"344","y":"3546","properties":{"size":"20","text":"Submit the updated code for a second review if needed."}},{"ID":"2768","typeID":"Arrow","zOrder":"153","w":"1","h":"766","measuredW":"150","measuredH":"100","x":"1462","y":"3266","properties":{"curvature":"0","leftArrow":"false","rightArrow":"false","color":"4273622","p0":{"x":0,"y":-0.48484848484849863},"p1":{"x":0.5,"y":0},"p2":{"x":0,"y":765.5873148069213}}},{"ID":"2769","typeID":"Arrow","zOrder":"154","w":"1236","h":"1","measuredW":"150","measuredH":"100","x":"227","y":"3643","properties":{"curvature":"0","leftArrow":"false","rightArrow":"false","color":"4273622","p0":{"x":0,"y":0},"p1":{"x":0.4999101217590421,"y":0.0002824717439428831},"p2":{"x":1235,"y":0}}},{"ID":"2770","typeID":"Canvas","zOrder":"155","w":"372","h":"50","measuredW":"100","measuredH":"70","x":"344","y":"3619","properties":{"color":"16776960"}},{"ID":"2771","typeID":"Label","zOrder":"156","measuredW":"308","measuredH":"28","x":"376","y":"3630","properties":{"size":"20","text":"After the Code Review (Reviewer)"}},{"ID":"2772","typeID":"TextArea","zOrder":"157","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"3715"},{"ID":"2773","typeID":"Label","zOrder":"158","measuredW":"845","measuredH":"28","x":"344","y":"3716","properties":{"size":"20","text":"Resolve conflicting opinions in a timely manner; don't let a PR sit around due to disagreement."}},{"ID":"2774","typeID":"TextArea","zOrder":"159","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"3756"},{"ID":"2775","typeID":"Label","zOrder":"160","measuredW":"554","measuredH":"28","x":"344","y":"3757","properties":{"size":"20","text":"Verify that all the feedback has been addressed by the author."}},{"ID":"2776","typeID":"TextArea","zOrder":"161","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"3797"},{"ID":"2777","typeID":"Label","zOrder":"162","measuredW":"942","measuredH":"28","x":"344","y":"3798","properties":{"size":"20","text":"Review the updated code and ensure that the suggested changes have been implemented as expected."}},{"ID":"2778","typeID":"TextArea","zOrder":"163","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"3836"},{"ID":"2779","typeID":"Label","zOrder":"164","measuredW":"444","measuredH":"28","x":"344","y":"3837","properties":{"size":"20","text":"Run the tests again and ensure that they all pass."}},{"ID":"2780","typeID":"TextArea","zOrder":"165","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"3876"},{"ID":"2781","typeID":"Label","zOrder":"166","measuredW":"548","measuredH":"28","x":"344","y":"3877","properties":{"size":"20","text":"Address any questions or concerns that the author may have."}},{"ID":"2782","typeID":"TextArea","zOrder":"167","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"3916"},{"ID":"2783","typeID":"Label","zOrder":"168","measuredW":"927","measuredH":"28","x":"344","y":"3917","properties":{"size":"20","text":"Be open to feedback from the author and be willing to make adjustments to your feedback if necessary."}},{"ID":"2784","typeID":"Arrow","zOrder":"169","w":"1236","h":"1","measuredW":"150","measuredH":"100","x":"227","y":"4032","properties":{"curvature":"0","leftArrow":"false","rightArrow":"false","color":"4273622","p0":{"x":0,"y":0},"p1":{"x":0.4999101217590421,"y":0.0002824717439428831},"p2":{"x":1235,"y":0}}},{"ID":"2785","typeID":"Canvas","zOrder":"170","w":"372","h":"50","measuredW":"100","measuredH":"70","x":"344","y":"4008","properties":{"color":"16776960"}},{"ID":"2786","typeID":"Label","zOrder":"171","measuredW":"311","measuredH":"28","x":"376","y":"4019","properties":{"size":"20","text":"After Approval (Author / Reviewer)"}},{"ID":"2787","typeID":"TextArea","zOrder":"172","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"4104"},{"ID":"2788","typeID":"Label","zOrder":"173","measuredW":"576","measuredH":"28","x":"344","y":"4105","properties":{"size":"20","text":"Merge the approved code change into the main/feature branch."}},{"ID":"2789","typeID":"TextArea","zOrder":"174","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"4144"},{"ID":"2790","typeID":"Label","zOrder":"175","measuredW":"769","measuredH":"28","x":"344","y":"4145","properties":{"size":"20","text":"Verify that the code change is functioning as expected in the production environment."}},{"ID":"2791","typeID":"TextArea","zOrder":"176","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"4184"},{"ID":"2792","typeID":"Label","zOrder":"177","measuredW":"868","measuredH":"28","x":"344","y":"4185","properties":{"size":"20","text":"Monitor the performance and functionality of the code change and address any issues that arise."}},{"ID":"2793","typeID":"TextArea","zOrder":"178","w":"30","h":"30","measuredW":"200","measuredH":"140","x":"298","y":"4223"},{"ID":"2794","typeID":"Label","zOrder":"179","measuredW":"516","measuredH":"28","x":"344","y":"4224","properties":{"size":"20","text":"Celebrate the successful completion of the code change!"}},{"ID":"2795","typeID":"Arrow","zOrder":"180","w":"1","h":"282","measuredW":"150","measuredH":"100","x":"226","y":"4032","properties":{"curvature":"0","leftArrow":"false","rightArrow":"false","color":"4273622","p0":{"x":0,"y":-0.48484848484849863},"p1":{"x":0.5,"y":0},"p2":{"x":0,"y":281.83656863446413}}},{"ID":"2796","typeID":"Arrow","zOrder":"181","w":"633","h":"1","measuredW":"150","measuredH":"100","x":"226","y":"4313","properties":{"curvature":"0","leftArrow":"false","rightArrow":"false","color":"4273622","p0":{"x":0,"y":0},"p1":{"x":0.4999101217590421,"y":0.0002824717439428831},"p2":{"x":633.1902987999596,"y":0}}},{"ID":"2797","typeID":"Arrow","zOrder":"182","w":"1","h":"194","measuredW":"150","measuredH":"100","x":"859","y":"4312","properties":{"curvature":"0","leftArrow":"false","rightArrow":"false","color":"4273622","p0":{"x":0,"y":-0.48484848484849863},"p1":{"x":0.5,"y":0},"p2":{"x":0,"y":193.49906869978804}}},{"ID":"2798","typeID":"Label","zOrder":"183","measuredW":"264","measuredH":"48","x":"728","y":"4536","properties":{"size":"40","text":"Keep Shipping"}},{"ID":"2800","typeID":"Arrow","zOrder":"184","w":"75","h":"1","measuredW":"150","measuredH":"100","x":"201","y":"372","properties":{"curvature":"0","leftArrow":"false","rightArrow":"false","stroke":"dotted","color":"16777215","p0":{"x":0,"y":0},"p1":{"x":0.4999999999999999,"y":0},"p2":{"x":75.31007493951245,"y":0}}},{"ID":"2801","typeID":"Label","zOrder":"185","measuredW":"171","measuredH":"48","x":"1304","y":"442","properties":{"size":"40","text":"Everyone","color":"13421772"}},{"ID":"2802","typeID":"Label","zOrder":"186","measuredW":"118","measuredH":"48","x":"1312","y":"1232","properties":{"size":"40","color":"13421772","text":"Author"}},{"ID":"2805","typeID":"Label","zOrder":"187","measuredW":"118","measuredH":"48","x":"1312","y":"1740","properties":{"size":"40","color":"13421772","text":"Author"}},{"ID":"2806","typeID":"Label","zOrder":"188","measuredW":"169","measuredH":"48","x":"1275","y":"2158","properties":{"size":"40","color":"13421772","text":"Reviewer"}},{"ID":"2807","typeID":"Label","zOrder":"189","measuredW":"169","measuredH":"48","x":"1275","y":"2641","properties":{"size":"40","color":"13421772","text":"Reviewer"}},{"ID":"2808","typeID":"Label","zOrder":"190","measuredW":"118","measuredH":"48","x":"1312","y":"3289","properties":{"size":"40","color":"13421772","text":"Author"}},{"ID":"2810","typeID":"Label","zOrder":"191","measuredW":"169","measuredH":"48","x":"1259","y":"3669","properties":{"size":"40","color":"13421772","text":"Reviewer"}},{"ID":"2811","typeID":"Label","zOrder":"192","measuredW":"327","measuredH":"48","x":"1133","y":"4063","properties":{"size":"40","color":"13421772","text":"Author / Reviewer"}}]},"attributes":{"name":"New Wireframe 9 copy 3","order":1000127.6123092113,"parentID":null,"notes":null},"branchID":"Master","resourceID":"A1A5999B-9C79-4DA0-ACC2-6623475C4F5B","mockupH":"4546","mockupW":"1276","measuredW":"1477","measuredH":"4681","version":"1.0"},"groupOffset":{"x":0,"y":0},"dependencies":[],"projectID":"file:///Users/kamranahmed/Desktop/AWS%20Roadmap.bmpr"} \ No newline at end of file +{ + "mockup": { + "controls": { + "control": [ + { + "ID": "2466", + "typeID": "Arrow", + "zOrder": "0", + "w": "1", + "h": "81", + "measuredW": "150", + "measuredH": "100", + "x": "859", + "y": "4412", + "properties": { + "curvature": "0", + "leftArrow": "false", + "rightArrow": "false", + "stroke": "dotted", + "color": "10027263", + "p0": { + "x": 0, + "y": 0 + }, + "p1": { + "x": 0.49999999999999994, + "y": 0 + }, + "p2": { + "x": 0, + "y": 81.09090909090901 + } + } + }, + { + "ID": "2471", + "typeID": "Arrow", + "zOrder": "1", + "w": "1234", + "h": "1", + "measuredW": "150", + "measuredH": "100", + "x": "239", + "y": "413", + "properties": { + "curvature": "0", + "leftArrow": "false", + "rightArrow": "false", + "color": "4273622", + "p0": { + "x": -0.3879633062732637, + "y": 0 + }, + "p1": { + "x": 0.4999449522687742, + "y": 0.0003335799224988863 + }, + "p2": { + "x": 1233.8055670724293, + "y": 0 + } + } + }, + { + "ID": "2472", + "typeID": "Canvas", + "zOrder": "45", + "w": "293", + "h": "50", + "measuredW": "100", + "measuredH": "70", + "x": "407", + "y": "387", + "properties": { + "color": "16776960" + } + }, + { + "ID": "2475", + "typeID": "Label", + "zOrder": "4", + "measuredW": "260", + "measuredH": "48", + "x": "730", + "y": "227", + "properties": { + "text": "Code Reviews", + "size": "40" + } + }, + { + "ID": "2476", + "typeID": "Canvas", + "zOrder": "5", + "w": "361", + "h": "150", + "measuredW": "100", + "measuredH": "70", + "x": "1116", + "y": "188" + }, + { + "ID": "2477", + "typeID": "Label", + "zOrder": "6", + "measuredW": "332", + "measuredH": "26", + "x": "1132", + "y": "206", + "properties": { + "text": "Find the detailed version of this checklist", + "size": "18" + } + }, + { + "ID": "2478", + "typeID": "Label", + "zOrder": "7", + "measuredW": "318", + "measuredH": "26", + "x": "1132", + "y": "234", + "properties": { + "size": "18", + "text": "With details on how to implement these" + } + }, + { + "ID": "2479", + "typeID": "__group__", + "zOrder": "8", + "measuredW": "329", + "measuredH": "51", + "w": "329", + "h": "51", + "x": "1132", + "y": "270", + "properties": { + "controlName": "ext_link:roadmap.sh" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Canvas", + "zOrder": "0", + "w": "329", + "h": "51", + "measuredW": "100", + "measuredH": "70", + "x": "0", + "y": "0", + "properties": { + "color": "4273622", + "borderColor": "4273622" + } + }, + { + "ID": "1", + "typeID": "Label", + "zOrder": "1", + "measuredW": "172", + "measuredH": "28", + "x": "79", + "y": "12", + "properties": { + "color": "16777215", + "size": "20", + "text": "https://roadmap.sh" + } + } + ] + } + } + }, + { + "ID": "2480", + "typeID": "Canvas", + "zOrder": "9", + "w": "373", + "h": "169", + "measuredW": "100", + "measuredH": "70", + "x": "225", + "y": "168" + }, + { + "ID": "2481", + "typeID": "__group__", + "zOrder": "10", + "measuredW": "160", + "measuredH": "27", + "w": "160", + "h": "27", + "x": "255", + "y": "242", + "properties": { + "controlName": "ext_link:roadmap.sh/roadmaps" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "127", + "measuredH": "26", + "x": "33", + "y": "0", + "properties": { + "size": "18", + "text": "Visit Roadmaps" + } + }, + { + "ID": "1", + "typeID": "__group__", + "zOrder": "1", + "measuredW": "24", + "measuredH": "24", + "w": "24", + "h": "24", + "x": "0", + "y": "3", + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Icon", + "zOrder": "0", + "measuredW": "24", + "measuredH": "24", + "x": "0", + "y": "0", + "properties": { + "color": "16777215", + "icon": { + "ID": "circle", + "size": "small" + } + } + }, + { + "ID": "1", + "typeID": "Icon", + "zOrder": "1", + "measuredW": "24", + "measuredH": "24", + "x": "0", + "y": "0", + "properties": { + "color": "10066329", + "icon": { + "ID": "check-circle", + "size": "small" + } + } + } + ] + } + } + } + ] + } + } + }, + { + "ID": "2482", + "typeID": "__group__", + "zOrder": "11", + "measuredW": "203", + "measuredH": "27", + "w": "203", + "h": "27", + "x": "255", + "y": "278", + "properties": { + "controlName": "ext_link:roadmap.sh/best-practices" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "170", + "measuredH": "26", + "x": "33", + "y": "0", + "properties": { + "size": "18", + "text": "Other Best Practices" + } + }, + { + "ID": "1", + "typeID": "__group__", + "zOrder": "1", + "measuredW": "24", + "measuredH": "24", + "w": "24", + "h": "24", + "x": "0", + "y": "3", + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Icon", + "zOrder": "0", + "measuredW": "24", + "measuredH": "24", + "x": "0", + "y": "0", + "properties": { + "color": "16777215", + "icon": { + "ID": "circle", + "size": "small" + } + } + }, + { + "ID": "1", + "typeID": "Icon", + "zOrder": "1", + "measuredW": "24", + "measuredH": "24", + "x": "0", + "y": "0", + "properties": { + "color": "10066329", + "icon": { + "ID": "check-circle", + "size": "small" + } + } + } + ] + } + } + } + ] + } + } + }, + { + "ID": "2483", + "typeID": "Label", + "zOrder": "12", + "measuredW": "150", + "measuredH": "32", + "x": "255", + "y": "192", + "properties": { + "size": "24", + "text": "More Content" + } + }, + { + "ID": "2484", + "typeID": "Arrow", + "zOrder": "13", + "w": "1", + "h": "76", + "measuredW": "150", + "measuredH": "100", + "x": "859", + "y": "135", + "properties": { + "curvature": "0", + "leftArrow": "false", + "rightArrow": "false", + "p0": { + "x": 0, + "y": 0 + }, + "p1": { + "x": 0.49999999999999994, + "y": 0 + }, + "p2": { + "x": 0, + "y": 76.17275043077757 + }, + "stroke": "dotted", + "color": "10027263" + } + }, + { + "ID": "2563", + "typeID": "Label", + "zOrder": "46", + "measuredW": "190", + "measuredH": "28", + "x": "459", + "y": "398", + "properties": { + "size": "20", + "text": "Team Wide Practices" + } + }, + { + "ID": "2564", + "typeID": "Arrow", + "zOrder": "14", + "w": "1", + "h": "123", + "measuredW": "150", + "measuredH": "100", + "x": "859", + "y": "288", + "properties": { + "curvature": "0", + "leftArrow": "false", + "rightArrow": "false", + "color": "4273622", + "p0": { + "x": 0, + "y": -0.48484848484849863 + }, + "p1": { + "x": 0.5, + "y": 0 + }, + "p2": { + "x": 0, + "y": 122.37977858123031 + } + } + }, + { + "ID": "2655", + "typeID": "Arrow", + "zOrder": "47", + "w": "1", + "h": "793", + "measuredW": "150", + "measuredH": "100", + "x": "237", + "y": "413", + "properties": { + "curvature": "0", + "leftArrow": "false", + "rightArrow": "false", + "color": "4273622", + "p0": { + "x": 0, + "y": -0.48484848484849863 + }, + "p1": { + "x": 0.5, + "y": 0 + }, + "p2": { + "x": 0, + "y": 792.1520096524373 + } + } + }, + { + "ID": "2656", + "typeID": "Arrow", + "zOrder": "48", + "w": "1224", + "h": "1", + "measuredW": "150", + "measuredH": "100", + "x": "239", + "y": "1206", + "properties": { + "curvature": "0", + "leftArrow": "false", + "rightArrow": "false", + "color": "4273622", + "p0": { + "x": 0, + "y": 0 + }, + "p1": { + "x": 0.4998545777165489, + "y": 0.00028245338618605997 + }, + "p2": { + "x": 1223, + "y": 0 + } + } + }, + { + "ID": "2657", + "typeID": "Canvas", + "zOrder": "49", + "w": "355", + "h": "50", + "measuredW": "100", + "measuredH": "70", + "x": "389", + "y": "1182", + "properties": { + "color": "16776960" + } + }, + { + "ID": "2658", + "typeID": "Label", + "zOrder": "50", + "measuredW": "266", + "measuredH": "28", + "x": "434", + "y": "1193", + "properties": { + "size": "20", + "text": "During Development (Author)" + } + }, + { + "ID": "2677", + "typeID": "Arrow", + "zOrder": "69", + "w": "1", + "h": "886", + "measuredW": "150", + "measuredH": "100", + "x": "1462", + "y": "1207", + "properties": { + "curvature": "0", + "leftArrow": "false", + "rightArrow": "false", + "color": "4273622", + "p0": { + "x": 0, + "y": -0.48484848484849863 + }, + "p1": { + "x": 0.5, + "y": 0 + }, + "p2": { + "x": 0, + "y": 885.5470493335324 + } + } + }, + { + "ID": "2678", + "typeID": "Arrow", + "zOrder": "70", + "w": "1236", + "h": "1", + "measuredW": "150", + "measuredH": "100", + "x": "225", + "y": "1684", + "properties": { + "curvature": "0", + "leftArrow": "false", + "rightArrow": "false", + "color": "4273622", + "p0": { + "x": 0, + "y": 0 + }, + "p1": { + "x": 0.4999101217590421, + "y": 0.0002824717439428831 + }, + "p2": { + "x": 1235, + "y": 0 + } + } + }, + { + "ID": "2679", + "typeID": "Canvas", + "zOrder": "71", + "w": "355", + "h": "50", + "measuredW": "100", + "measuredH": "70", + "x": "376", + "y": "1660", + "properties": { + "color": "16776960" + } + }, + { + "ID": "2680", + "typeID": "Label", + "zOrder": "72", + "measuredW": "283", + "measuredH": "28", + "x": "412", + "y": "1671", + "properties": { + "size": "20", + "text": "After the Development (Author)" + } + }, + { + "ID": "2695", + "typeID": "Arrow", + "zOrder": "87", + "w": "1236", + "h": "1", + "measuredW": "150", + "measuredH": "100", + "x": "225", + "y": "2092", + "properties": { + "curvature": "0", + "leftArrow": "false", + "rightArrow": "false", + "color": "4273622", + "p0": { + "x": 0, + "y": 0 + }, + "p1": { + "x": 0.4999101217590421, + "y": 0.0002824717439428831 + }, + "p2": { + "x": 1235, + "y": 0 + } + } + }, + { + "ID": "2696", + "typeID": "Canvas", + "zOrder": "88", + "w": "355", + "h": "50", + "measuredW": "100", + "measuredH": "70", + "x": "372", + "y": "2067", + "properties": { + "color": "16776960" + } + }, + { + "ID": "2697", + "typeID": "Label", + "zOrder": "89", + "measuredW": "264", + "measuredH": "28", + "x": "408", + "y": "2078", + "properties": { + "size": "20", + "text": "Before Reviewing (Reviewer)" + } + }, + { + "ID": "2714", + "typeID": "Arrow", + "zOrder": "106", + "w": "1", + "h": "1123", + "measuredW": "150", + "measuredH": "100", + "x": "225", + "y": "2094", + "properties": { + "curvature": "0", + "leftArrow": "false", + "rightArrow": "false", + "color": "4273622", + "p0": { + "x": 0, + "y": -0.48484848484849863 + }, + "p1": { + "x": 0.5, + "y": 0 + }, + "p2": { + "x": 0, + "y": 1122.2949887323225 + } + } + }, + { + "ID": "2719", + "typeID": "Arrow", + "zOrder": "107", + "w": "1236", + "h": "1", + "measuredW": "150", + "measuredH": "100", + "x": "225", + "y": "2569", + "properties": { + "curvature": "0", + "leftArrow": "false", + "rightArrow": "false", + "color": "4273622", + "p0": { + "x": 0, + "y": 0 + }, + "p1": { + "x": 0.4999101217590421, + "y": 0.0002824717439428831 + }, + "p2": { + "x": 1235, + "y": 0 + } + } + }, + { + "ID": "2720", + "typeID": "Canvas", + "zOrder": "108", + "w": "355", + "h": "50", + "measuredW": "100", + "measuredH": "70", + "x": "372", + "y": "2544", + "properties": { + "color": "16776960" + } + }, + { + "ID": "2721", + "typeID": "Label", + "zOrder": "109", + "measuredW": "291", + "measuredH": "28", + "x": "404", + "y": "2555", + "properties": { + "size": "20", + "text": "During Code Review (Reviewer)" + } + }, + { + "ID": "2753", + "typeID": "Arrow", + "zOrder": "138", + "w": "1236", + "h": "1", + "measuredW": "150", + "measuredH": "100", + "x": "225", + "y": "3215", + "properties": { + "curvature": "0", + "leftArrow": "false", + "rightArrow": "false", + "color": "4273622", + "p0": { + "x": 0, + "y": 0 + }, + "p1": { + "x": 0.4999101217590421, + "y": 0.0002824717439428831 + }, + "p2": { + "x": 1235, + "y": 0 + } + } + }, + { + "ID": "2754", + "typeID": "Canvas", + "zOrder": "139", + "w": "355", + "h": "50", + "measuredW": "100", + "measuredH": "70", + "x": "348", + "y": "3189", + "properties": { + "color": "16776960" + } + }, + { + "ID": "2755", + "typeID": "Label", + "zOrder": "140", + "measuredW": "283", + "measuredH": "28", + "x": "384", + "y": "3200", + "properties": { + "size": "20", + "text": "After the Code Review (Author)" + } + }, + { + "ID": "2768", + "typeID": "Arrow", + "zOrder": "153", + "w": "1", + "h": "735", + "measuredW": "150", + "measuredH": "100", + "x": "1462", + "y": "3216", + "properties": { + "curvature": "0", + "leftArrow": "false", + "rightArrow": "false", + "color": "4273622", + "p0": { + "x": 0, + "y": -0.48484848484849863 + }, + "p1": { + "x": 0.5, + "y": 0 + }, + "p2": { + "x": 0, + "y": 734.4572997643622 + } + } + }, + { + "ID": "2769", + "typeID": "Arrow", + "zOrder": "154", + "w": "1236", + "h": "1", + "measuredW": "150", + "measuredH": "100", + "x": "227", + "y": "3583", + "properties": { + "curvature": "0", + "leftArrow": "false", + "rightArrow": "false", + "color": "4273622", + "p0": { + "x": 0, + "y": 0 + }, + "p1": { + "x": 0.4999101217590421, + "y": 0.0002824717439428831 + }, + "p2": { + "x": 1235, + "y": 0 + } + } + }, + { + "ID": "2770", + "typeID": "Canvas", + "zOrder": "155", + "w": "372", + "h": "50", + "measuredW": "100", + "measuredH": "70", + "x": "344", + "y": "3559", + "properties": { + "color": "16776960" + } + }, + { + "ID": "2771", + "typeID": "Label", + "zOrder": "156", + "measuredW": "308", + "measuredH": "28", + "x": "376", + "y": "3570", + "properties": { + "size": "20", + "text": "After the Code Review (Reviewer)" + } + }, + { + "ID": "2784", + "typeID": "Arrow", + "zOrder": "169", + "w": "1236", + "h": "1", + "measuredW": "150", + "measuredH": "100", + "x": "227", + "y": "3952", + "properties": { + "curvature": "0", + "leftArrow": "false", + "rightArrow": "false", + "color": "4273622", + "p0": { + "x": 0, + "y": 0 + }, + "p1": { + "x": 0.4999101217590421, + "y": 0.0002824717439428831 + }, + "p2": { + "x": 1235, + "y": 0 + } + } + }, + { + "ID": "2785", + "typeID": "Canvas", + "zOrder": "170", + "w": "372", + "h": "50", + "measuredW": "100", + "measuredH": "70", + "x": "344", + "y": "3928", + "properties": { + "color": "16776960" + } + }, + { + "ID": "2786", + "typeID": "Label", + "zOrder": "171", + "measuredW": "311", + "measuredH": "28", + "x": "376", + "y": "3939", + "properties": { + "size": "20", + "text": "After Approval (Author / Reviewer)" + } + }, + { + "ID": "2795", + "typeID": "Arrow", + "zOrder": "180", + "w": "1", + "h": "282", + "measuredW": "150", + "measuredH": "100", + "x": "226", + "y": "3952", + "properties": { + "curvature": "0", + "leftArrow": "false", + "rightArrow": "false", + "color": "4273622", + "p0": { + "x": 0, + "y": -0.48484848484849863 + }, + "p1": { + "x": 0.5, + "y": 0 + }, + "p2": { + "x": 0, + "y": 281.83656863446413 + } + } + }, + { + "ID": "2796", + "typeID": "Arrow", + "zOrder": "181", + "w": "633", + "h": "1", + "measuredW": "150", + "measuredH": "100", + "x": "226", + "y": "4233", + "properties": { + "curvature": "0", + "leftArrow": "false", + "rightArrow": "false", + "color": "4273622", + "p0": { + "x": 0, + "y": 0 + }, + "p1": { + "x": 0.4999101217590421, + "y": 0.0002824717439428831 + }, + "p2": { + "x": 633.1902987999596, + "y": 0 + } + } + }, + { + "ID": "2797", + "typeID": "Arrow", + "zOrder": "182", + "w": "1", + "h": "92", + "measuredW": "150", + "measuredH": "100", + "x": "859", + "y": "4234", + "properties": { + "curvature": "0", + "leftArrow": "false", + "rightArrow": "false", + "color": "4273622", + "p0": { + "x": 0, + "y": -0.48484848484849863 + }, + "p1": { + "x": 0.5, + "y": 0 + }, + "p2": { + "x": 0, + "y": 91.64625415628961 + } + } + }, + { + "ID": "2798", + "typeID": "Label", + "zOrder": "183", + "measuredW": "211", + "measuredH": "40", + "x": "754", + "y": "4348", + "properties": { + "text": "Keep Shipping", + "size": "32" + } + }, + { + "ID": "2800", + "typeID": "Arrow", + "zOrder": "184", + "w": "75", + "h": "1", + "measuredW": "150", + "measuredH": "100", + "x": "201", + "y": "372", + "properties": { + "curvature": "0", + "leftArrow": "false", + "rightArrow": "false", + "stroke": "dotted", + "color": "16777215", + "p0": { + "x": 0, + "y": 0 + }, + "p1": { + "x": 0.4999999999999999, + "y": 0 + }, + "p2": { + "x": 75.31007493951245, + "y": 0 + } + } + }, + { + "ID": "2801", + "typeID": "Label", + "zOrder": "185", + "measuredW": "171", + "measuredH": "48", + "x": "1264", + "y": "442", + "properties": { + "size": "40", + "text": "Everyone", + "color": "13421772" + } + }, + { + "ID": "2802", + "typeID": "Label", + "zOrder": "186", + "measuredW": "118", + "measuredH": "48", + "x": "1317", + "y": "1242", + "properties": { + "size": "40", + "color": "13421772", + "text": "Author" + } + }, + { + "ID": "2805", + "typeID": "Label", + "zOrder": "187", + "measuredW": "118", + "measuredH": "48", + "x": "1317", + "y": "1710", + "properties": { + "size": "40", + "color": "13421772", + "text": "Author" + } + }, + { + "ID": "2806", + "typeID": "Label", + "zOrder": "188", + "measuredW": "169", + "measuredH": "48", + "x": "1266", + "y": "2137", + "properties": { + "size": "40", + "color": "13421772", + "text": "Reviewer" + } + }, + { + "ID": "2807", + "typeID": "Label", + "zOrder": "189", + "measuredW": "169", + "measuredH": "48", + "x": "1266", + "y": "2604", + "properties": { + "size": "40", + "color": "13421772", + "text": "Reviewer" + } + }, + { + "ID": "2808", + "typeID": "Label", + "zOrder": "190", + "measuredW": "118", + "measuredH": "48", + "x": "1317", + "y": "3249", + "properties": { + "size": "40", + "color": "13421772", + "text": "Author" + } + }, + { + "ID": "2810", + "typeID": "Label", + "zOrder": "191", + "measuredW": "169", + "measuredH": "48", + "x": "1266", + "y": "3609", + "properties": { + "size": "40", + "color": "13421772", + "text": "Reviewer" + } + }, + { + "ID": "2811", + "typeID": "Label", + "zOrder": "192", + "measuredW": "327", + "measuredH": "48", + "x": "1108", + "y": "3988", + "properties": { + "color": "13421772", + "size": "40", + "text": "Author / Reviewer" + } + }, + { + "ID": "2812", + "typeID": "__group__", + "zOrder": "3", + "measuredW": "474", + "measuredH": "28", + "w": "474", + "h": "28", + "x": "334", + "y": "483", + "properties": { + "controlName": "document-process" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "474", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "text": "Document and standardize the code review process.", + "size": "20" + } + } + ] + } + } + }, + { + "ID": "2813", + "typeID": "__group__", + "zOrder": "2", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "288", + "y": "482", + "properties": { + "controlName": "check:document-process" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2814", + "typeID": "__group__", + "zOrder": "16", + "measuredW": "552", + "measuredH": "28", + "w": "552", + "h": "28", + "x": "334", + "y": "525", + "properties": { + "controlName": "code-review-purpose" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "552", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "text": "Ensure that the purpose of code reviews is clear to everyone.", + "size": "20" + } + } + ] + } + } + }, + { + "ID": "2815", + "typeID": "__group__", + "zOrder": "15", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "288", + "y": "524", + "properties": { + "controlName": "check:code-review-purpose" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2816", + "typeID": "__group__", + "zOrder": "38", + "measuredW": "630", + "measuredH": "28", + "w": "630", + "h": "28", + "x": "334", + "y": "565", + "properties": { + "controlName": "definition-of-done" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "630", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "text": "Ensure that “Definition of Done” is documented and clear to everyone", + "size": "20" + } + } + ] + } + } + }, + { + "ID": "2817", + "typeID": "__group__", + "zOrder": "37", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "288", + "y": "564", + "properties": { + "controlName": "check:definition-of-done" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2819", + "typeID": "__group__", + "zOrder": "34", + "measuredW": "516", + "measuredH": "28", + "w": "516", + "h": "28", + "x": "334", + "y": "610", + "properties": { + "controlName": "encourage-participation" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "516", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "text": "Encourage team members to participate in code reviews.", + "size": "20" + } + } + ] + } + } + }, + { + "ID": "2820", + "typeID": "__group__", + "zOrder": "33", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "288", + "y": "609", + "properties": { + "controlName": "check:encourage-participation" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2821", + "typeID": "__group__", + "zOrder": "18", + "measuredW": "496", + "measuredH": "28", + "w": "496", + "h": "28", + "x": "334", + "y": "652", + "properties": { + "controlName": "conflict-resolution" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "496", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "text": "Define a process for conflict resolution in code reviews.", + "size": "20" + } + } + ] + } + } + }, + { + "ID": "2822", + "typeID": "__group__", + "zOrder": "17", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "288", + "y": "651", + "properties": { + "controlName": "check:conflict-resolution" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2823", + "typeID": "__group__", + "zOrder": "20", + "measuredW": "448", + "measuredH": "28", + "w": "448", + "h": "28", + "x": "334", + "y": "692", + "properties": { + "controlName": "style-guide-preferences" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "448", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "text": "Have a definitive style guide for style preferences.", + "size": "20" + } + } + ] + } + } + }, + { + "ID": "2824", + "typeID": "__group__", + "zOrder": "19", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "288", + "y": "691", + "properties": { + "controlName": "check:style-guide-preferences" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2825", + "typeID": "__group__", + "zOrder": "22", + "measuredW": "595", + "measuredH": "28", + "w": "595", + "h": "28", + "x": "335", + "y": "734", + "properties": { + "controlName": "use-automation" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "595", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "text": "Use automation to speed up the code reviews (linting, sniffing etc)", + "size": "20" + } + } + ] + } + } + }, + { + "ID": "2826", + "typeID": "__group__", + "zOrder": "21", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "288", + "y": "733", + "properties": { + "controlName": "check:use-automation" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2827", + "typeID": "__group__", + "zOrder": "24", + "measuredW": "509", + "measuredH": "28", + "w": "509", + "h": "28", + "x": "335", + "y": "775", + "properties": { + "controlName": "set-clear-expectations" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "509", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "text": "Set clear expectations for code review turnaround times.", + "size": "20" + } + } + ] + } + } + }, + { + "ID": "2828", + "typeID": "__group__", + "zOrder": "23", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "288", + "y": "774", + "properties": { + "controlName": "check:set-clear-expectations" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2829", + "typeID": "__group__", + "zOrder": "26", + "measuredW": "629", + "measuredH": "28", + "w": "629", + "h": "28", + "x": "336", + "y": "816", + "properties": { + "controlName": "adequate-review-time" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "629", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "text": "Provide adequate time for code reviews and ensure that it is a priority.", + "size": "20" + } + } + ] + } + } + }, + { + "ID": "2830", + "typeID": "__group__", + "zOrder": "25", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "288", + "y": "815", + "properties": { + "controlName": "check:adequate-review-time" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2831", + "typeID": "__group__", + "zOrder": "28", + "measuredW": "648", + "measuredH": "28", + "w": "648", + "h": "28", + "x": "336", + "y": "857", + "properties": { + "controlName": "knowledge-sharing" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "648", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "text": "Use code reviews as an opportunity for knowledge sharing and learning.", + "size": "20" + } + } + ] + } + } + }, + { + "ID": "2832", + "typeID": "__group__", + "zOrder": "27", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "288", + "y": "856", + "properties": { + "controlName": "check:knowledge-sharing" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2833", + "typeID": "__group__", + "zOrder": "36", + "measuredW": "690", + "measuredH": "28", + "w": "690", + "h": "28", + "x": "336", + "y": "898", + "properties": { + "controlName": "cross-functional-knowledge" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "690", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "text": "Encourage reviewing code in unknown-areas for cross-functional knowledge.", + "size": "20" + } + } + ] + } + } + }, + { + "ID": "2834", + "typeID": "__group__", + "zOrder": "35", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "288", + "y": "897", + "properties": { + "controlName": "check:cross-functional-knowledge" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2835", + "typeID": "__group__", + "zOrder": "30", + "measuredW": "481", + "measuredH": "28", + "w": "481", + "h": "28", + "x": "336", + "y": "940", + "properties": { + "controlName": "monitor-reviews" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "481", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "text": "Constantly monitor and improve code review process.", + "size": "20" + } + } + ] + } + } + }, + { + "ID": "2836", + "typeID": "__group__", + "zOrder": "29", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "288", + "y": "939", + "properties": { + "controlName": "check:monitor-reviews" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2837", + "typeID": "__group__", + "zOrder": "32", + "measuredW": "645", + "measuredH": "28", + "w": "645", + "h": "28", + "x": "337", + "y": "980", + "properties": { + "controlName": "recognition-rewards" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "645", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "text": "Recognition and rewards for those with track record of quality feedback.", + "size": "20" + } + } + ] + } + } + }, + { + "ID": "2838", + "typeID": "__group__", + "zOrder": "31", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "288", + "y": "979", + "properties": { + "controlName": "check:recognition-rewards" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2839", + "typeID": "__group__", + "zOrder": "40", + "measuredW": "828", + "measuredH": "28", + "w": "828", + "h": "28", + "x": "337", + "y": "1022", + "properties": { + "controlName": "no-one-way-process" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "828", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "text": "Encourage communication/collaboration; avoid treating code reviews as a one-way process.", + "size": "20" + } + } + ] + } + } + }, + { + "ID": "2840", + "typeID": "__group__", + "zOrder": "39", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "288", + "y": "1021", + "properties": { + "controlName": "check:no-one-way-process" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2841", + "typeID": "__group__", + "zOrder": "42", + "measuredW": "965", + "measuredH": "28", + "w": "965", + "h": "28", + "x": "337", + "y": "1063", + "properties": { + "controlName": "trends-issues-finding" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "965", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Hold regular code review sessions to discuss broader trends or issues that arise during the review process." + } + } + ] + } + } + }, + { + "ID": "2842", + "typeID": "__group__", + "zOrder": "41", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "288", + "y": "1062", + "properties": { + "controlName": "check:trends-issues-finding" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2843", + "typeID": "__group__", + "zOrder": "44", + "measuredW": "878", + "measuredH": "28", + "w": "878", + "h": "28", + "x": "337", + "y": "1107", + "properties": { + "controlName": "seek-feedback" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "878", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Encourage authors to seek feedback during development before submitting a formal code review." + } + } + ] + } + } + }, + { + "ID": "2844", + "typeID": "__group__", + "zOrder": "43", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "288", + "y": "1106", + "properties": { + "controlName": "check:seek-feedback" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2845", + "typeID": "__group__", + "zOrder": "52", + "measuredW": "533", + "measuredH": "28", + "w": "533", + "h": "28", + "x": "324", + "y": "1271", + "properties": { + "controlName": "follow-guidelines" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "533", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Follow the coding standards and any other team guidelines." + } + } + ] + } + } + }, + { + "ID": "2846", + "typeID": "__group__", + "zOrder": "51", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "1270", + "properties": { + "controlName": "check:follow-guidelines" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2847", + "typeID": "__group__", + "zOrder": "54", + "measuredW": "567", + "measuredH": "28", + "w": "567", + "h": "28", + "x": "324", + "y": "1313", + "properties": { + "controlName": "consistency-everywhere" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "567", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Stay consistent with the overall project design and architecture." + } + } + ] + } + } + }, + { + "ID": "2848", + "typeID": "__group__", + "zOrder": "53", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "1312", + "properties": { + "controlName": "check:consistency-everywhere" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2849", + "typeID": "__group__", + "zOrder": "56", + "measuredW": "421", + "measuredH": "28", + "w": "421", + "h": "28", + "x": "324", + "y": "1353", + "properties": { + "controlName": "failing-text-bug" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "421", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Write a failing test if the change is for a bug fix." + } + } + ] + } + } + }, + { + "ID": "2850", + "typeID": "__group__", + "zOrder": "55", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "1352", + "properties": { + "controlName": "check:failing-text-bug" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2851", + "typeID": "__group__", + "zOrder": "58", + "measuredW": "569", + "measuredH": "28", + "w": "569", + "h": "28", + "x": "324", + "y": "1394", + "properties": { + "controlName": "complex-tasks-breakage" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "569", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Break down complex tasks into smaller easily manageable PRs." + } + } + ] + } + } + }, + { + "ID": "2852", + "typeID": "__group__", + "zOrder": "57", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "1393", + "properties": { + "controlName": "check:complex-tasks-breakage" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2853", + "typeID": "__group__", + "zOrder": "60", + "measuredW": "576", + "measuredH": "28", + "w": "576", + "h": "28", + "x": "324", + "y": "1437", + "properties": { + "controlName": "impact-of-change" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "576", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Consider the impact of the change on other parts of the system." + } + } + ] + } + } + }, + { + "ID": "2854", + "typeID": "__group__", + "zOrder": "59", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "1436", + "properties": { + "controlName": "check:impact-of-change" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2855", + "typeID": "__group__", + "zOrder": "62", + "measuredW": "844", + "measuredH": "28", + "w": "844", + "h": "28", + "x": "324", + "y": "1480", + "properties": { + "controlName": "note-questions-for-review" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "844", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Take notes on any questions or concerns about the change to discuss them during the review." + } + } + ] + } + } + }, + { + "ID": "2856", + "typeID": "__group__", + "zOrder": "61", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "1479", + "properties": { + "controlName": "check:note-questions-for-review" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2857", + "typeID": "__group__", + "zOrder": "64", + "measuredW": "238", + "measuredH": "28", + "w": "238", + "h": "28", + "x": "324", + "y": "1521", + "properties": { + "controlName": "write-automated-tests" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "238", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Write the automated tests." + } + } + ] + } + } + }, + { + "ID": "2858", + "typeID": "__group__", + "zOrder": "63", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "1520", + "properties": { + "controlName": "check:write-automated-tests" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2859", + "typeID": "__group__", + "zOrder": "66", + "measuredW": "566", + "measuredH": "28", + "w": "566", + "h": "28", + "x": "324", + "y": "1561", + "properties": { + "controlName": "document-new-feature" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "566", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Write the documentation for the feature or changes if required." + } + } + ] + } + } + }, + { + "ID": "2860", + "typeID": "__group__", + "zOrder": "65", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "1559", + "properties": { + "controlName": "check:document-new-feature" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2861", + "typeID": "__group__", + "zOrder": "68", + "measuredW": "709", + "measuredH": "28", + "w": "709", + "h": "28", + "x": "324", + "y": "1600", + "properties": { + "controlName": "update-docs-changes" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "709", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Update any documentation that may have made obsolete through the changes." + } + } + ] + } + } + }, + { + "ID": "2862", + "typeID": "__group__", + "zOrder": "67", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "1599", + "properties": { + "controlName": "check:update-docs-changes" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2863", + "typeID": "__group__", + "zOrder": "74", + "measuredW": "418", + "measuredH": "28", + "w": "418", + "h": "28", + "x": "322", + "y": "1752", + "properties": { + "controlName": "self-review" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "418", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Review your code before submitting for review." + } + } + ] + } + } + }, + { + "ID": "2864", + "typeID": "__group__", + "zOrder": "73", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "276", + "y": "1751", + "properties": { + "controlName": "check:self-review" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2865", + "typeID": "__group__", + "zOrder": "76", + "measuredW": "979", + "measuredH": "28", + "w": "979", + "h": "28", + "x": "322", + "y": "1794", + "properties": { + "controlName": "changes-ready" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "979", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Ensure that the changes are complete and ready for review, including all necessary tests and documentation." + } + } + ] + } + } + }, + { + "ID": "2866", + "typeID": "__group__", + "zOrder": "75", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "276", + "y": "1793", + "properties": { + "controlName": "check:changes-ready" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2867", + "typeID": "__group__", + "zOrder": "78", + "measuredW": "760", + "measuredH": "28", + "w": "760", + "h": "28", + "x": "322", + "y": "1836", + "properties": { + "controlName": "tested-in-dev" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "760", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Verify that the code change has been properly tested in a development environment." + } + } + ] + } + } + }, + { + "ID": "2868", + "typeID": "__group__", + "zOrder": "77", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "276", + "y": "1835", + "properties": { + "controlName": "check:tested-in-dev" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2869", + "typeID": "__group__", + "zOrder": "80", + "measuredW": "813", + "measuredH": "28", + "w": "813", + "h": "28", + "x": "323", + "y": "1877", + "properties": { + "controlName": "adhere-guidelines" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "813", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Double-check that the code adheres to the project's coding standards and best practices. " + } + } + ] + } + } + }, + { + "ID": "2870", + "typeID": "__group__", + "zOrder": "79", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "277", + "y": "1876", + "properties": { + "controlName": "check:adhere-guidelines" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2871", + "typeID": "__group__", + "zOrder": "82", + "measuredW": "1023", + "measuredH": "28", + "w": "1023", + "h": "28", + "x": "323", + "y": "1920", + "properties": { + "controlName": "potential-issues-review" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "1023", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Identify any potential performance, security, or scalability concerns and note them for discussion during the review." + } + } + ] + } + } + }, + { + "ID": "2872", + "typeID": "__group__", + "zOrder": "81", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "277", + "y": "1919", + "properties": { + "controlName": "check:potential-issues-review" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2873", + "typeID": "__group__", + "zOrder": "84", + "measuredW": "989", + "measuredH": "28", + "w": "989", + "h": "28", + "x": "323", + "y": "1961", + "properties": { + "controlName": "proper-description-pr" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "989", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Make sure to add proper title, description, any screenshots, relevant links, configuration changes etc in the PR." + } + } + ] + } + } + }, + { + "ID": "2874", + "typeID": "__group__", + "zOrder": "83", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "277", + "y": "1960", + "properties": { + "controlName": "check:proper-description-pr" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2875", + "typeID": "__group__", + "zOrder": "86", + "measuredW": "1069", + "measuredH": "28", + "w": "1069", + "h": "28", + "x": "323", + "y": "2003", + "properties": { + "controlName": "open-mind-author" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "1069", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Approach the review process with an open mind, and be willing to learn from and collaborate with other team members." + } + } + ] + } + } + }, + { + "ID": "2876", + "typeID": "__group__", + "zOrder": "85", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "277", + "y": "2002", + "properties": { + "controlName": "check:open-mind-author" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2877", + "typeID": "__group__", + "zOrder": "91", + "measuredW": "663", + "measuredH": "28", + "w": "663", + "h": "28", + "x": "324", + "y": "2153", + "properties": { + "controlName": "learn-context-reqs" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "663", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Understand the requirements and the context in which change was made." + } + } + ] + } + } + }, + { + "ID": "2878", + "typeID": "__group__", + "zOrder": "90", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "2152", + "properties": { + "controlName": "check:learn-context-reqs" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2879", + "typeID": "__group__", + "zOrder": "93", + "measuredW": "879", + "measuredH": "28", + "w": "879", + "h": "28", + "x": "324", + "y": "2193", + "properties": { + "controlName": "prepare-list" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "879", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Based on the requirements, prepare a list of items that should have been covered in the changes." + } + } + ] + } + } + }, + { + "ID": "2880", + "typeID": "__group__", + "zOrder": "92", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "2192", + "properties": { + "controlName": "check:prepare-list" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2881", + "typeID": "__group__", + "zOrder": "95", + "measuredW": "561", + "measuredH": "28", + "w": "561", + "h": "28", + "x": "324", + "y": "2232", + "properties": { + "controlName": "architecture-understanding" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "561", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Ensure that you understand the codebase and its architecture." + } + } + ] + } + } + }, + { + "ID": "2882", + "typeID": "__group__", + "zOrder": "94", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "2231", + "properties": { + "controlName": "check:architecture-understanding" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2883", + "typeID": "__group__", + "zOrder": "97", + "measuredW": "664", + "measuredH": "28", + "w": "664", + "h": "28", + "x": "324", + "y": "2273", + "properties": { + "controlName": "review-docs-design" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "664", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Review any documentation or design specifications related to the change." + } + } + ] + } + } + }, + { + "ID": "2884", + "typeID": "__group__", + "zOrder": "96", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "2272", + "properties": { + "controlName": "check:review-docs-design" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2885", + "typeID": "__group__", + "zOrder": "99", + "measuredW": "653", + "measuredH": "28", + "w": "653", + "h": "28", + "x": "324", + "y": "2312", + "properties": { + "controlName": "list-review-risks-issues" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "653", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Make list of any potential risks or issues that could arise with the change." + } + } + ] + } + } + }, + { + "ID": "2886", + "typeID": "__group__", + "zOrder": "98", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "2311", + "properties": { + "controlName": "check:list-review-risks-issues" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2887", + "typeID": "__group__", + "zOrder": "101", + "measuredW": "1121", + "measuredH": "28", + "w": "1121", + "h": "28", + "x": "324", + "y": "2352", + "properties": { + "controlName": "open-mind-reviewer" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "1121", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Approach the process with an open mind; be willing to provide constructive feedback and collaborate to improve code quality" + } + } + ] + } + } + }, + { + "ID": "2888", + "typeID": "__group__", + "zOrder": "100", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "2351", + "properties": { + "controlName": "check:open-mind-reviewer" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2889", + "typeID": "__group__", + "zOrder": "103", + "measuredW": "813", + "measuredH": "28", + "w": "813", + "h": "28", + "x": "324", + "y": "2393", + "properties": { + "controlName": "quality-code-overall" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "813", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Consider the overall quality of the code, including readability, maintainability, and scalability." + } + } + ] + } + } + }, + { + "ID": "2890", + "typeID": "__group__", + "zOrder": "102", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "2392", + "properties": { + "controlName": "check:quality-code-overall" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2891", + "typeID": "__group__", + "zOrder": "105", + "measuredW": "925", + "measuredH": "28", + "w": "925", + "h": "28", + "x": "324", + "y": "2433", + "properties": { + "controlName": "determine-review-level" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "925", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Determine the appropriate level of review needed based on the scope and impact of the code change." + } + } + ] + } + } + }, + { + "ID": "2892", + "typeID": "__group__", + "zOrder": "104", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "2432", + "properties": { + "controlName": "check:determine-review-level" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2893", + "typeID": "__group__", + "zOrder": "113", + "measuredW": "992", + "measuredH": "28", + "w": "992", + "h": "28", + "x": "324", + "y": "2477", + "properties": { + "controlName": "collaborate-reviewer-author" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "992", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Be willing to collaborate with the author to resolve any issues or concerns that arise during the review process." + } + } + ] + } + } + }, + { + "ID": "2894", + "typeID": "__group__", + "zOrder": "112", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "2476", + "properties": { + "controlName": "check:collaborate-reviewer-author" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2895", + "typeID": "__group__", + "zOrder": "111", + "measuredW": "900", + "measuredH": "28", + "w": "900", + "h": "28", + "x": "324", + "y": "2641", + "properties": { + "controlName": "professional-feedback" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "900", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Be respectful and professional in your feedback, avoiding personal attacks or derogatory comments." + } + } + ] + } + } + }, + { + "ID": "2896", + "typeID": "__group__", + "zOrder": "110", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "2640", + "properties": { + "controlName": "check:professional-feedback" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2897", + "typeID": "__group__", + "zOrder": "115", + "measuredW": "1091", + "measuredH": "28", + "w": "1091", + "h": "28", + "x": "324", + "y": "2682", + "properties": { + "controlName": "clear-feedback" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "1091", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Provide clear and actionable feedback, including specific suggestions for improvement and explanations of any concerns." + } + } + ] + } + } + }, + { + "ID": "2898", + "typeID": "__group__", + "zOrder": "114", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "2681", + "properties": { + "controlName": "check:clear-feedback" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2899", + "typeID": "__group__", + "zOrder": "117", + "measuredW": "902", + "measuredH": "28", + "w": "902", + "h": "28", + "x": "324", + "y": "2721", + "properties": { + "controlName": "potential-issues-reviewer" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "902", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Identify any potential performance, security, or scalability concerns, and discuss them with the author." + } + } + ] + } + } + }, + { + "ID": "2900", + "typeID": "__group__", + "zOrder": "116", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "2720", + "properties": { + "controlName": "check:potential-issues-reviewer" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2901", + "typeID": "__group__", + "zOrder": "119", + "measuredW": "606", + "measuredH": "28", + "w": "606", + "h": "28", + "x": "324", + "y": "2761", + "properties": { + "controlName": "prioritize-feedback" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "606", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Prioritize your feedback, focusing on the most important issues first." + } + } + ] + } + } + }, + { + "ID": "2902", + "typeID": "__group__", + "zOrder": "118", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "2760", + "properties": { + "controlName": "check:prioritize-feedback" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2903", + "typeID": "__group__", + "zOrder": "121", + "measuredW": "1051", + "measuredH": "28", + "w": "1051", + "h": "28", + "x": "324", + "y": "2801", + "properties": { + "controlName": "review-tests" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "1051", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Review any tests included with the code change to verify that they adequately cover the functionality and edge cases." + } + } + ] + } + } + }, + { + "ID": "2904", + "typeID": "__group__", + "zOrder": "120", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "2800", + "properties": { + "controlName": "check:review-tests" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2905", + "typeID": "__group__", + "zOrder": "123", + "measuredW": "819", + "measuredH": "28", + "w": "819", + "h": "28", + "x": "324", + "y": "2841", + "properties": { + "controlName": "code-guide-best-practices-adherence" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "819", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Ensure that the code change adheres to the project's coding standards and best practices." + } + } + ] + } + } + }, + { + "ID": "2906", + "typeID": "__group__", + "zOrder": "122", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "2840", + "properties": { + "controlName": "check:code-guide-best-practices-adherence" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2907", + "typeID": "__group__", + "zOrder": "125", + "measuredW": "531", + "measuredH": "28", + "w": "531", + "h": "28", + "x": "324", + "y": "2880", + "properties": { + "controlName": "review-docs-updated" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "531", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Ensure that the relevant documentation has been updated." + } + } + ] + } + } + }, + { + "ID": "2908", + "typeID": "__group__", + "zOrder": "124", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "2879", + "properties": { + "controlName": "check:review-docs-updated" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2909", + "typeID": "__group__", + "zOrder": "127", + "measuredW": "1038", + "measuredH": "28", + "w": "1038", + "h": "28", + "x": "324", + "y": "2920", + "properties": { + "controlName": "team-wide-style-followed" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "1038", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Team wide styleguide is the absolute authority styling. Verify changes against those instead of personal preferences" + } + } + ] + } + } + }, + { + "ID": "2910", + "typeID": "__group__", + "zOrder": "126", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "2919", + "properties": { + "controlName": "check:team-wide-style-followed" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2911", + "typeID": "__group__", + "zOrder": "129", + "measuredW": "960", + "measuredH": "28", + "w": "960", + "h": "28", + "x": "324", + "y": "2960", + "properties": { + "controlName": "nitpick-comments" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "960", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Leave comments to suggest improvements, but prefix it with \"Nit\" if it's not critical to meeting the standards" + } + } + ] + } + } + }, + { + "ID": "2912", + "typeID": "__group__", + "zOrder": "128", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "2959", + "properties": { + "controlName": "check:nitpick-comments" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2913", + "typeID": "__group__", + "zOrder": "131", + "measuredW": "413", + "measuredH": "28", + "w": "413", + "h": "28", + "x": "324", + "y": "3002", + "properties": { + "controlName": "continuous-improvement-over-perfection" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "413", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Seek continuous improvement, not perfection." + } + } + ] + } + } + }, + { + "ID": "2914", + "typeID": "__group__", + "zOrder": "130", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "3001", + "properties": { + "controlName": "check:continuous-improvement-over-perfection" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2915", + "typeID": "__group__", + "zOrder": "133", + "measuredW": "528", + "measuredH": "28", + "w": "528", + "h": "28", + "x": "324", + "y": "3042", + "properties": { + "controlName": "short-term-long-term-considerations" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "528", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Keep the short-term and long-term considerations in mind." + } + } + ] + } + } + }, + { + "ID": "2916", + "typeID": "__group__", + "zOrder": "132", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "3041", + "properties": { + "controlName": "check:short-term-long-term-considerations" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2917", + "typeID": "__group__", + "zOrder": "135", + "measuredW": "743", + "measuredH": "28", + "w": "743", + "h": "28", + "x": "324", + "y": "3082", + "properties": { + "controlName": "pair-programming-reviews" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "743", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Consider using pair programming as an alternative or supplement to code reviews." + } + } + ] + } + } + }, + { + "ID": "2918", + "typeID": "__group__", + "zOrder": "134", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "3081", + "properties": { + "controlName": "check:pair-programming-reviews" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2919", + "typeID": "__group__", + "zOrder": "137", + "measuredW": "1019", + "measuredH": "28", + "w": "1019", + "h": "28", + "x": "324", + "y": "3122", + "properties": { + "controlName": "positive-feedback-criticism" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "1019", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Provide positive feedback in addition to constructive criticism, to reinforce good practices and boost team morale." + } + } + ] + } + } + }, + { + "ID": "2920", + "typeID": "__group__", + "zOrder": "136", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "3121", + "properties": { + "controlName": "check:positive-feedback-criticism" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2921", + "typeID": "__group__", + "zOrder": "142", + "measuredW": "704", + "measuredH": "28", + "w": "704", + "h": "28", + "x": "324", + "y": "3281", + "properties": { + "controlName": "address-feedback-received" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "704", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Address all the feedback received, including any concerns or questions raised." + } + } + ] + } + } + }, + { + "ID": "2922", + "typeID": "__group__", + "zOrder": "141", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "3280", + "properties": { + "controlName": "check:address-feedback-received" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2923", + "typeID": "__group__", + "zOrder": "144", + "measuredW": "686", + "measuredH": "28", + "w": "686", + "h": "28", + "x": "324", + "y": "3321", + "properties": { + "controlName": "implement-changes-explanations" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "686", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Implement the suggested changes and provide explanations where needed." + } + } + ] + } + } + }, + { + "ID": "2924", + "typeID": "__group__", + "zOrder": "143", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "3320", + "properties": { + "controlName": "check:implement-changes-explanations" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2925", + "typeID": "__group__", + "zOrder": "146", + "measuredW": "586", + "measuredH": "28", + "w": "586", + "h": "28", + "x": "324", + "y": "3362", + "properties": { + "controlName": "run-tests-ensure-passing" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "586", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Run the tests and ensure that they all pass after making changes" + } + } + ] + } + } + }, + { + "ID": "2926", + "typeID": "__group__", + "zOrder": "145", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "3361", + "properties": { + "controlName": "check:run-tests-ensure-passing" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2927", + "typeID": "__group__", + "zOrder": "148", + "measuredW": "642", + "measuredH": "28", + "w": "642", + "h": "28", + "x": "324", + "y": "3402", + "properties": { + "controlName": "update-review-changes-docs" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "642", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Update any documentation or code comments affected by the changes." + } + } + ] + } + } + }, + { + "ID": "2928", + "typeID": "__group__", + "zOrder": "147", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "3401", + "properties": { + "controlName": "check:update-review-changes-docs" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2929", + "typeID": "__group__", + "zOrder": "150", + "measuredW": "709", + "measuredH": "28", + "w": "709", + "h": "28", + "x": "324", + "y": "3443", + "properties": { + "controlName": "seek-team-members-feedback" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "709", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Seek feedback from other team members if you are unsure about the changes." + } + } + ] + } + } + }, + { + "ID": "2930", + "typeID": "__group__", + "zOrder": "149", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "3442", + "properties": { + "controlName": "check:seek-team-members-feedback" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2931", + "typeID": "__group__", + "zOrder": "152", + "measuredW": "505", + "measuredH": "28", + "w": "505", + "h": "28", + "x": "324", + "y": "3486", + "properties": { + "controlName": "submit-re-review" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "505", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Submit the updated code for a second review if needed." + } + } + ] + } + } + }, + { + "ID": "2932", + "typeID": "__group__", + "zOrder": "151", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "3485", + "properties": { + "controlName": "check:submit-re-review" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2933", + "typeID": "__group__", + "zOrder": "158", + "measuredW": "845", + "measuredH": "28", + "w": "845", + "h": "28", + "x": "324", + "y": "3656", + "properties": { + "controlName": "resolve-conflicts-timely" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "845", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Resolve conflicting opinions in a timely manner; don't let a PR sit around due to disagreement." + } + } + ] + } + } + }, + { + "ID": "2934", + "typeID": "__group__", + "zOrder": "157", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "3655", + "properties": { + "controlName": "check:resolve-conflicts-timely" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2935", + "typeID": "__group__", + "zOrder": "160", + "measuredW": "554", + "measuredH": "28", + "w": "554", + "h": "28", + "x": "324", + "y": "3697", + "properties": { + "controlName": "verify-changes-addressed" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "554", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Verify that all the feedback has been addressed by the author." + } + } + ] + } + } + }, + { + "ID": "2936", + "typeID": "__group__", + "zOrder": "159", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "3696", + "properties": { + "controlName": "check:verify-changes-addressed" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2937", + "typeID": "__group__", + "zOrder": "162", + "measuredW": "942", + "measuredH": "28", + "w": "942", + "h": "28", + "x": "324", + "y": "3738", + "properties": { + "controlName": "review-updated-code" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "942", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Review the updated code and ensure that the suggested changes have been implemented as expected." + } + } + ] + } + } + }, + { + "ID": "2938", + "typeID": "__group__", + "zOrder": "161", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "3737", + "properties": { + "controlName": "check:review-updated-code" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2939", + "typeID": "__group__", + "zOrder": "164", + "measuredW": "444", + "measuredH": "28", + "w": "444", + "h": "28", + "x": "324", + "y": "3777", + "properties": { + "controlName": "re-run-tests-verify" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "444", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Run the tests again and ensure that they all pass." + } + } + ] + } + } + }, + { + "ID": "2940", + "typeID": "__group__", + "zOrder": "163", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "3776", + "properties": { + "controlName": "check:re-run-tests-verify" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2941", + "typeID": "__group__", + "zOrder": "166", + "measuredW": "548", + "measuredH": "28", + "w": "548", + "h": "28", + "x": "324", + "y": "3817", + "properties": { + "controlName": "address-author-concerns" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "548", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Address any questions or concerns that the author may have." + } + } + ] + } + } + }, + { + "ID": "2942", + "typeID": "__group__", + "zOrder": "165", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "3816", + "properties": { + "controlName": "check:address-author-concerns" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2943", + "typeID": "__group__", + "zOrder": "168", + "measuredW": "927", + "measuredH": "28", + "w": "927", + "h": "28", + "x": "324", + "y": "3857", + "properties": { + "controlName": "author-feedback-welcomed" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "927", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Be open to feedback from the author and be willing to make adjustments to your feedback if necessary." + } + } + ] + } + } + }, + { + "ID": "2944", + "typeID": "__group__", + "zOrder": "167", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "278", + "y": "3856", + "properties": { + "controlName": "check:author-feedback-welcomed" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2945", + "typeID": "__group__", + "zOrder": "173", + "measuredW": "576", + "measuredH": "28", + "w": "576", + "h": "28", + "x": "344", + "y": "4025", + "properties": { + "controlName": "merge-approved-code" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "576", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Merge the approved code change into the main/feature branch." + } + } + ] + } + } + }, + { + "ID": "2946", + "typeID": "__group__", + "zOrder": "172", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "298", + "y": "4024", + "properties": { + "controlName": "check:merge-approved-code" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2947", + "typeID": "__group__", + "zOrder": "175", + "measuredW": "769", + "measuredH": "28", + "w": "769", + "h": "28", + "x": "344", + "y": "4065", + "properties": { + "controlName": "change-functioning" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "769", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Verify that the code change is functioning as expected in the production environment." + } + } + ] + } + } + }, + { + "ID": "2948", + "typeID": "__group__", + "zOrder": "174", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "298", + "y": "4064", + "properties": { + "controlName": "check:change-functioning" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2949", + "typeID": "__group__", + "zOrder": "177", + "measuredW": "868", + "measuredH": "28", + "w": "868", + "h": "28", + "x": "344", + "y": "4105", + "properties": { + "controlName": "monitor-performance" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "868", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Monitor the performance and functionality of the code change and address any issues that arise." + } + } + ] + } + } + }, + { + "ID": "2950", + "typeID": "__group__", + "zOrder": "176", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "298", + "y": "4104", + "properties": { + "controlName": "check:monitor-performance" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2951", + "typeID": "__group__", + "zOrder": "179", + "measuredW": "516", + "measuredH": "28", + "w": "516", + "h": "28", + "x": "344", + "y": "4144", + "properties": { + "controlName": "celebrate-success" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "Label", + "zOrder": "0", + "measuredW": "516", + "measuredH": "28", + "x": "0", + "y": "0", + "properties": { + "size": "20", + "text": "Celebrate the successful completion of the code change!" + } + } + ] + } + } + }, + { + "ID": "2952", + "typeID": "__group__", + "zOrder": "178", + "measuredW": "30", + "measuredH": "30", + "w": "30", + "h": "30", + "x": "298", + "y": "4143", + "properties": { + "controlName": "check:celebrate-success" + }, + "children": { + "controls": { + "control": [ + { + "ID": "0", + "typeID": "TextArea", + "zOrder": "0", + "w": "30", + "h": "30", + "measuredW": "200", + "measuredH": "140", + "x": "0", + "y": "0" + } + ] + } + } + }, + { + "ID": "2953", + "typeID": "Arrow", + "zOrder": "193", + "w": "75", + "h": "1", + "measuredW": "150", + "measuredH": "100", + "x": "1415", + "y": "372", + "properties": { + "curvature": "0", + "leftArrow": "false", + "rightArrow": "false", + "stroke": "dotted", + "color": "16777215", + "p0": { + "x": 0, + "y": 0 + }, + "p1": { + "x": 0.4999999999999999, + "y": 0 + }, + "p2": { + "x": 75.31007493951245, + "y": 0 + } + } + } + ] + }, + "attributes": { + "name": "New Wireframe 9 copy 3", + "order": 1000127.6123092113, + "parentID": null, + "notes": null + }, + "branchID": "Master", + "resourceID": "A1A5999B-9C79-4DA0-ACC2-6623475C4F5B", + "mockupH": "4358", + "mockupW": "1289", + "measuredW": "1490", + "measuredH": "4493", + "version": "1.0" + }, + "groupOffset": { + "x": 0, + "y": 0 + }, + "dependencies": [], + "projectID": "file:///Users/kamranahmed/Desktop/AWS%20Roadmap.bmpr" +} \ No newline at end of file diff --git a/src/data/best-practices/code-review/code-review.md b/src/data/best-practices/code-review/code-review.md index cf7abee67..fc3730ec4 100644 --- a/src/data/best-practices/code-review/code-review.md +++ b/src/data/best-practices/code-review/code-review.md @@ -10,7 +10,7 @@ title: 'Code Review Best Practices' description: 'Detailed list of best practices for effective code reviews and quality' dimensions: width: 968 - height: 3429.4 + height: 3254.98 schema: headline: 'Code Review Best Practices' description: 'Discover the essential best practices for effective code review and improve the quality of your software development. From establishing clear objectives to providing constructive feedback, this interactive guide covers everything you need to know to optimize your code review process and ensure the delivery of high-quality code.' diff --git a/src/data/best-practices/code-review/content/address-author-concerns.md b/src/data/best-practices/code-review/content/address-author-concerns.md new file mode 100644 index 000000000..0e2b889eb --- /dev/null +++ b/src/data/best-practices/code-review/content/address-author-concerns.md @@ -0,0 +1 @@ +# Address any questions or concerns that the author may have. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/address-feedback-received.md b/src/data/best-practices/code-review/content/address-feedback-received.md new file mode 100644 index 000000000..eddd1fd60 --- /dev/null +++ b/src/data/best-practices/code-review/content/address-feedback-received.md @@ -0,0 +1 @@ +# Address all the feedback received, including any concerns or questions raised. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/adequate-review-time.md b/src/data/best-practices/code-review/content/adequate-review-time.md new file mode 100644 index 000000000..2e5910700 --- /dev/null +++ b/src/data/best-practices/code-review/content/adequate-review-time.md @@ -0,0 +1 @@ +# Provide adequate time for code reviews and ensure that it is a priority. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/adhere-guidelines.md b/src/data/best-practices/code-review/content/adhere-guidelines.md new file mode 100644 index 000000000..4dabbd1a2 --- /dev/null +++ b/src/data/best-practices/code-review/content/adhere-guidelines.md @@ -0,0 +1 @@ +# Double-check that the code adheres to the project's coding standards and best practices. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/architecture-understanding.md b/src/data/best-practices/code-review/content/architecture-understanding.md new file mode 100644 index 000000000..84112ca59 --- /dev/null +++ b/src/data/best-practices/code-review/content/architecture-understanding.md @@ -0,0 +1 @@ +# Ensure that you understand the codebase and its architecture. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/author-feedback-welcomed.md b/src/data/best-practices/code-review/content/author-feedback-welcomed.md new file mode 100644 index 000000000..82adffc5a --- /dev/null +++ b/src/data/best-practices/code-review/content/author-feedback-welcomed.md @@ -0,0 +1 @@ +# Be open to feedback from the author and be willing to make adjustments to your feedback if necessary. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/celebrate-success.md b/src/data/best-practices/code-review/content/celebrate-success.md new file mode 100644 index 000000000..42d1021b6 --- /dev/null +++ b/src/data/best-practices/code-review/content/celebrate-success.md @@ -0,0 +1 @@ +# Celebrate the successful completion of the code change! \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/change-functioning.md b/src/data/best-practices/code-review/content/change-functioning.md new file mode 100644 index 000000000..fe00aa779 --- /dev/null +++ b/src/data/best-practices/code-review/content/change-functioning.md @@ -0,0 +1 @@ +# Verify that the code change is functioning as expected in the production environment. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/changes-ready.md b/src/data/best-practices/code-review/content/changes-ready.md new file mode 100644 index 000000000..21db481bf --- /dev/null +++ b/src/data/best-practices/code-review/content/changes-ready.md @@ -0,0 +1 @@ +# Ensure that the changes are complete and ready for review, including all necessary tests and documentation. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/clear-feedback.md b/src/data/best-practices/code-review/content/clear-feedback.md new file mode 100644 index 000000000..d32fcfa5c --- /dev/null +++ b/src/data/best-practices/code-review/content/clear-feedback.md @@ -0,0 +1 @@ +# Provide clear and actionable feedback, including specific suggestions for improvement and explanations of any concerns. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/code-guide-best-practices-adherence.md b/src/data/best-practices/code-review/content/code-guide-best-practices-adherence.md new file mode 100644 index 000000000..0f7b59e5f --- /dev/null +++ b/src/data/best-practices/code-review/content/code-guide-best-practices-adherence.md @@ -0,0 +1 @@ +# Ensure that the code change adheres to the project's coding standards and best practices. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/code-review-purpose.md b/src/data/best-practices/code-review/content/code-review-purpose.md new file mode 100644 index 000000000..9c898cec0 --- /dev/null +++ b/src/data/best-practices/code-review/content/code-review-purpose.md @@ -0,0 +1 @@ +# Ensure that the purpose of code reviews is clear to everyone. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/collaborate-reviewer-author.md b/src/data/best-practices/code-review/content/collaborate-reviewer-author.md new file mode 100644 index 000000000..498d0e5d2 --- /dev/null +++ b/src/data/best-practices/code-review/content/collaborate-reviewer-author.md @@ -0,0 +1 @@ +# Be willing to collaborate with the author to resolve any issues or concerns that arise during the review process. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/complex-tasks-breakage.md b/src/data/best-practices/code-review/content/complex-tasks-breakage.md new file mode 100644 index 000000000..e098d95ec --- /dev/null +++ b/src/data/best-practices/code-review/content/complex-tasks-breakage.md @@ -0,0 +1 @@ +# Break down complex tasks into smaller easily manageable PRs. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/conflict-resolution.md b/src/data/best-practices/code-review/content/conflict-resolution.md new file mode 100644 index 000000000..778f8d6b6 --- /dev/null +++ b/src/data/best-practices/code-review/content/conflict-resolution.md @@ -0,0 +1 @@ +# Define a process for conflict resolution in code reviews. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/consistency-everywhere.md b/src/data/best-practices/code-review/content/consistency-everywhere.md new file mode 100644 index 000000000..fec4f175d --- /dev/null +++ b/src/data/best-practices/code-review/content/consistency-everywhere.md @@ -0,0 +1 @@ +# Stay consistent with the overall project design and architecture. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/continuous-improvement-over-perfection.md b/src/data/best-practices/code-review/content/continuous-improvement-over-perfection.md new file mode 100644 index 000000000..56da7eb35 --- /dev/null +++ b/src/data/best-practices/code-review/content/continuous-improvement-over-perfection.md @@ -0,0 +1 @@ +# Seek continuous improvement, not perfection. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/cross-functional-knowledge.md b/src/data/best-practices/code-review/content/cross-functional-knowledge.md new file mode 100644 index 000000000..9a7bc22a4 --- /dev/null +++ b/src/data/best-practices/code-review/content/cross-functional-knowledge.md @@ -0,0 +1 @@ +# Encourage reviewing code in unknown-areas for cross-functional knowledge. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/definition-of-done.md b/src/data/best-practices/code-review/content/definition-of-done.md new file mode 100644 index 000000000..45070ee6a --- /dev/null +++ b/src/data/best-practices/code-review/content/definition-of-done.md @@ -0,0 +1 @@ +# Ensure that “Definition of Done” is documented and clear to everyone \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/determine-review-level.md b/src/data/best-practices/code-review/content/determine-review-level.md new file mode 100644 index 000000000..daf7c7cc1 --- /dev/null +++ b/src/data/best-practices/code-review/content/determine-review-level.md @@ -0,0 +1 @@ +# Determine the appropriate level of review needed based on the scope and impact of the code change. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/document-new-feature.md b/src/data/best-practices/code-review/content/document-new-feature.md new file mode 100644 index 000000000..1c2914fc1 --- /dev/null +++ b/src/data/best-practices/code-review/content/document-new-feature.md @@ -0,0 +1 @@ +# Write the documentation for the feature or changes if required. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/document-process.md b/src/data/best-practices/code-review/content/document-process.md new file mode 100644 index 000000000..f57df8b3a --- /dev/null +++ b/src/data/best-practices/code-review/content/document-process.md @@ -0,0 +1 @@ +# Document and standardize the code review process. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/encourage-participation.md b/src/data/best-practices/code-review/content/encourage-participation.md new file mode 100644 index 000000000..8d85dfc6a --- /dev/null +++ b/src/data/best-practices/code-review/content/encourage-participation.md @@ -0,0 +1 @@ +# Encourage team members to participate in code reviews. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/failing-text-bug.md b/src/data/best-practices/code-review/content/failing-text-bug.md new file mode 100644 index 000000000..7077e9fb4 --- /dev/null +++ b/src/data/best-practices/code-review/content/failing-text-bug.md @@ -0,0 +1 @@ +# Write a failing test if the change is for a bug fix. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/follow-guidelines.md b/src/data/best-practices/code-review/content/follow-guidelines.md new file mode 100644 index 000000000..ecfec2d4a --- /dev/null +++ b/src/data/best-practices/code-review/content/follow-guidelines.md @@ -0,0 +1 @@ +# Follow the coding standards and any other team guidelines. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/impact-of-change.md b/src/data/best-practices/code-review/content/impact-of-change.md new file mode 100644 index 000000000..88e628fe3 --- /dev/null +++ b/src/data/best-practices/code-review/content/impact-of-change.md @@ -0,0 +1 @@ +# Consider the impact of the change on other parts of the system. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/implement-changes-explanations.md b/src/data/best-practices/code-review/content/implement-changes-explanations.md new file mode 100644 index 000000000..35afdd4fd --- /dev/null +++ b/src/data/best-practices/code-review/content/implement-changes-explanations.md @@ -0,0 +1 @@ +# Implement the suggested changes and provide explanations where needed. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/index.md b/src/data/best-practices/code-review/content/index.md new file mode 100644 index 000000000..4e768b56d --- /dev/null +++ b/src/data/best-practices/code-review/content/index.md @@ -0,0 +1 @@ +# \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/knowledge-sharing.md b/src/data/best-practices/code-review/content/knowledge-sharing.md new file mode 100644 index 000000000..5add977f9 --- /dev/null +++ b/src/data/best-practices/code-review/content/knowledge-sharing.md @@ -0,0 +1 @@ +# Use code reviews as an opportunity for knowledge sharing and learning. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/learn-context-reqs.md b/src/data/best-practices/code-review/content/learn-context-reqs.md new file mode 100644 index 000000000..8a41264c4 --- /dev/null +++ b/src/data/best-practices/code-review/content/learn-context-reqs.md @@ -0,0 +1 @@ +# Understand the requirements and the context in which change was made. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/list-review-risks-issues.md b/src/data/best-practices/code-review/content/list-review-risks-issues.md new file mode 100644 index 000000000..d030e4656 --- /dev/null +++ b/src/data/best-practices/code-review/content/list-review-risks-issues.md @@ -0,0 +1 @@ +# Make list of any potential risks or issues that could arise with the change. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/merge-approved-code.md b/src/data/best-practices/code-review/content/merge-approved-code.md new file mode 100644 index 000000000..289beefab --- /dev/null +++ b/src/data/best-practices/code-review/content/merge-approved-code.md @@ -0,0 +1 @@ +# Merge the approved code change into the main/feature branch. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/monitor-performance.md b/src/data/best-practices/code-review/content/monitor-performance.md new file mode 100644 index 000000000..d22033dec --- /dev/null +++ b/src/data/best-practices/code-review/content/monitor-performance.md @@ -0,0 +1 @@ +# Monitor the performance and functionality of the code change and address any issues that arise. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/monitor-reviews.md b/src/data/best-practices/code-review/content/monitor-reviews.md new file mode 100644 index 000000000..f0ed73645 --- /dev/null +++ b/src/data/best-practices/code-review/content/monitor-reviews.md @@ -0,0 +1 @@ +# Constantly monitor and improve code review process. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/nitpick-comments.md b/src/data/best-practices/code-review/content/nitpick-comments.md new file mode 100644 index 000000000..33403d2a2 --- /dev/null +++ b/src/data/best-practices/code-review/content/nitpick-comments.md @@ -0,0 +1 @@ +# Leave comments to suggest improvements, but prefix it with "Nit" if it's not critical to meeting the standards \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/no-one-way-process.md b/src/data/best-practices/code-review/content/no-one-way-process.md new file mode 100644 index 000000000..956a8f011 --- /dev/null +++ b/src/data/best-practices/code-review/content/no-one-way-process.md @@ -0,0 +1 @@ +# Encourage communication/collaboration; avoid treating code reviews as a one-way process. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/note-questions-for-review.md b/src/data/best-practices/code-review/content/note-questions-for-review.md new file mode 100644 index 000000000..a95e5e835 --- /dev/null +++ b/src/data/best-practices/code-review/content/note-questions-for-review.md @@ -0,0 +1 @@ +# Take notes on any questions or concerns about the change to discuss them during the review. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/open-mind-author.md b/src/data/best-practices/code-review/content/open-mind-author.md new file mode 100644 index 000000000..645c1f400 --- /dev/null +++ b/src/data/best-practices/code-review/content/open-mind-author.md @@ -0,0 +1 @@ +# Approach the review process with an open mind, and be willing to learn from and collaborate with other team members. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/open-mind-reviewer.md b/src/data/best-practices/code-review/content/open-mind-reviewer.md new file mode 100644 index 000000000..df71b8709 --- /dev/null +++ b/src/data/best-practices/code-review/content/open-mind-reviewer.md @@ -0,0 +1 @@ +# Approach the process with an open mind; be willing to provide constructive feedback and collaborate to improve code quality \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/pair-programming-reviews.md b/src/data/best-practices/code-review/content/pair-programming-reviews.md new file mode 100644 index 000000000..d33915ea7 --- /dev/null +++ b/src/data/best-practices/code-review/content/pair-programming-reviews.md @@ -0,0 +1 @@ +# Consider using pair programming as an alternative or supplement to code reviews. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/positive-feedback-criticism.md b/src/data/best-practices/code-review/content/positive-feedback-criticism.md new file mode 100644 index 000000000..7dd16774d --- /dev/null +++ b/src/data/best-practices/code-review/content/positive-feedback-criticism.md @@ -0,0 +1 @@ +# Provide positive feedback in addition to constructive criticism, to reinforce good practices and boost team morale. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/potential-issues-review.md b/src/data/best-practices/code-review/content/potential-issues-review.md new file mode 100644 index 000000000..b0a851ae2 --- /dev/null +++ b/src/data/best-practices/code-review/content/potential-issues-review.md @@ -0,0 +1 @@ +# Identify any potential performance, security, or scalability concerns and note them for discussion during the review. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/potential-issues-reviewer.md b/src/data/best-practices/code-review/content/potential-issues-reviewer.md new file mode 100644 index 000000000..84ae6a066 --- /dev/null +++ b/src/data/best-practices/code-review/content/potential-issues-reviewer.md @@ -0,0 +1 @@ +# Identify any potential performance, security, or scalability concerns, and discuss them with the author. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/prepare-list.md b/src/data/best-practices/code-review/content/prepare-list.md new file mode 100644 index 000000000..82a2299b8 --- /dev/null +++ b/src/data/best-practices/code-review/content/prepare-list.md @@ -0,0 +1 @@ +# Based on the requirements, prepare a list of items that should have been covered in the changes. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/prioritize-feedback.md b/src/data/best-practices/code-review/content/prioritize-feedback.md new file mode 100644 index 000000000..4ad1d70c1 --- /dev/null +++ b/src/data/best-practices/code-review/content/prioritize-feedback.md @@ -0,0 +1 @@ +# Prioritize your feedback, focusing on the most important issues first. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/professional-feedback.md b/src/data/best-practices/code-review/content/professional-feedback.md new file mode 100644 index 000000000..79ba415c5 --- /dev/null +++ b/src/data/best-practices/code-review/content/professional-feedback.md @@ -0,0 +1 @@ +# Be respectful and professional in your feedback, avoiding personal attacks or derogatory comments. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/proper-description-pr.md b/src/data/best-practices/code-review/content/proper-description-pr.md new file mode 100644 index 000000000..22cec0c89 --- /dev/null +++ b/src/data/best-practices/code-review/content/proper-description-pr.md @@ -0,0 +1 @@ +# Make sure to add proper title, description, any screenshots, relevant links, configuration changes etc in the PR. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/quality-code-overall.md b/src/data/best-practices/code-review/content/quality-code-overall.md new file mode 100644 index 000000000..7cbd97918 --- /dev/null +++ b/src/data/best-practices/code-review/content/quality-code-overall.md @@ -0,0 +1 @@ +# Consider the overall quality of the code, including readability, maintainability, and scalability. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/re-run-tests-verify.md b/src/data/best-practices/code-review/content/re-run-tests-verify.md new file mode 100644 index 000000000..049776591 --- /dev/null +++ b/src/data/best-practices/code-review/content/re-run-tests-verify.md @@ -0,0 +1 @@ +# Run the tests again and ensure that they all pass. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/recognition-rewards.md b/src/data/best-practices/code-review/content/recognition-rewards.md new file mode 100644 index 000000000..6f1a7859b --- /dev/null +++ b/src/data/best-practices/code-review/content/recognition-rewards.md @@ -0,0 +1 @@ +# Recognition and rewards for those with track record of quality feedback. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/resolve-conflicts-timely.md b/src/data/best-practices/code-review/content/resolve-conflicts-timely.md new file mode 100644 index 000000000..87035fb1a --- /dev/null +++ b/src/data/best-practices/code-review/content/resolve-conflicts-timely.md @@ -0,0 +1 @@ +# Resolve conflicting opinions in a timely manner; don't let a PR sit around due to disagreement. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/review-docs-design.md b/src/data/best-practices/code-review/content/review-docs-design.md new file mode 100644 index 000000000..034a9d641 --- /dev/null +++ b/src/data/best-practices/code-review/content/review-docs-design.md @@ -0,0 +1 @@ +# Review any documentation or design specifications related to the change. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/review-docs-updated.md b/src/data/best-practices/code-review/content/review-docs-updated.md new file mode 100644 index 000000000..099295d88 --- /dev/null +++ b/src/data/best-practices/code-review/content/review-docs-updated.md @@ -0,0 +1 @@ +# Ensure that the relevant documentation has been updated. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/review-tests.md b/src/data/best-practices/code-review/content/review-tests.md new file mode 100644 index 000000000..2a5e154f7 --- /dev/null +++ b/src/data/best-practices/code-review/content/review-tests.md @@ -0,0 +1 @@ +# Review any tests included with the code change to verify that they adequately cover the functionality and edge cases. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/review-updated-code.md b/src/data/best-practices/code-review/content/review-updated-code.md new file mode 100644 index 000000000..f817f70d9 --- /dev/null +++ b/src/data/best-practices/code-review/content/review-updated-code.md @@ -0,0 +1 @@ +# Review the updated code and ensure that the suggested changes have been implemented as expected. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/run-tests-ensure-passing.md b/src/data/best-practices/code-review/content/run-tests-ensure-passing.md new file mode 100644 index 000000000..5a0eef193 --- /dev/null +++ b/src/data/best-practices/code-review/content/run-tests-ensure-passing.md @@ -0,0 +1 @@ +# Run the tests and ensure that they all pass after making changes \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/seek-feedback.md b/src/data/best-practices/code-review/content/seek-feedback.md new file mode 100644 index 000000000..95f1317bc --- /dev/null +++ b/src/data/best-practices/code-review/content/seek-feedback.md @@ -0,0 +1 @@ +# Encourage authors to seek feedback during development before submitting a formal code review. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/seek-team-members-feedback.md b/src/data/best-practices/code-review/content/seek-team-members-feedback.md new file mode 100644 index 000000000..355d32d73 --- /dev/null +++ b/src/data/best-practices/code-review/content/seek-team-members-feedback.md @@ -0,0 +1 @@ +# Seek feedback from other team members if you are unsure about the changes. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/self-review.md b/src/data/best-practices/code-review/content/self-review.md new file mode 100644 index 000000000..67bbd3d36 --- /dev/null +++ b/src/data/best-practices/code-review/content/self-review.md @@ -0,0 +1 @@ +# Review your code before submitting for review. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/set-clear-expectations.md b/src/data/best-practices/code-review/content/set-clear-expectations.md new file mode 100644 index 000000000..7e4e2a89b --- /dev/null +++ b/src/data/best-practices/code-review/content/set-clear-expectations.md @@ -0,0 +1 @@ +# Set clear expectations for code review turnaround times. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/short-term-long-term-considerations.md b/src/data/best-practices/code-review/content/short-term-long-term-considerations.md new file mode 100644 index 000000000..89c0f23db --- /dev/null +++ b/src/data/best-practices/code-review/content/short-term-long-term-considerations.md @@ -0,0 +1 @@ +# Keep the short-term and long-term considerations in mind. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/style-guide-preferences.md b/src/data/best-practices/code-review/content/style-guide-preferences.md new file mode 100644 index 000000000..7b8539442 --- /dev/null +++ b/src/data/best-practices/code-review/content/style-guide-preferences.md @@ -0,0 +1 @@ +# Have a definitive style guide for style preferences. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/submit-re-review.md b/src/data/best-practices/code-review/content/submit-re-review.md new file mode 100644 index 000000000..81aa26508 --- /dev/null +++ b/src/data/best-practices/code-review/content/submit-re-review.md @@ -0,0 +1 @@ +# Submit the updated code for a second review if needed. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/team-wide-style-followed.md b/src/data/best-practices/code-review/content/team-wide-style-followed.md new file mode 100644 index 000000000..84d70fce6 --- /dev/null +++ b/src/data/best-practices/code-review/content/team-wide-style-followed.md @@ -0,0 +1 @@ +# Team wide styleguide is the absolute authority styling. Verify changes against those instead of personal preferences \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/tested-in-dev.md b/src/data/best-practices/code-review/content/tested-in-dev.md new file mode 100644 index 000000000..504881222 --- /dev/null +++ b/src/data/best-practices/code-review/content/tested-in-dev.md @@ -0,0 +1 @@ +# Verify that the code change has been properly tested in a development environment. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/trends-issues-finding.md b/src/data/best-practices/code-review/content/trends-issues-finding.md new file mode 100644 index 000000000..5db8f82af --- /dev/null +++ b/src/data/best-practices/code-review/content/trends-issues-finding.md @@ -0,0 +1 @@ +# Hold regular code review sessions to discuss broader trends or issues that arise during the review process. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/update-docs-changes.md b/src/data/best-practices/code-review/content/update-docs-changes.md new file mode 100644 index 000000000..cf0858c8e --- /dev/null +++ b/src/data/best-practices/code-review/content/update-docs-changes.md @@ -0,0 +1 @@ +# Update any documentation that may have made obsolete through the changes. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/update-review-changes-docs.md b/src/data/best-practices/code-review/content/update-review-changes-docs.md new file mode 100644 index 000000000..8273fd73e --- /dev/null +++ b/src/data/best-practices/code-review/content/update-review-changes-docs.md @@ -0,0 +1 @@ +# Update any documentation or code comments affected by the changes. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/use-automation.md b/src/data/best-practices/code-review/content/use-automation.md new file mode 100644 index 000000000..3fcfb440d --- /dev/null +++ b/src/data/best-practices/code-review/content/use-automation.md @@ -0,0 +1 @@ +# Use automation to speed up the code reviews (linting, sniffing etc) \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/verify-changes-addressed.md b/src/data/best-practices/code-review/content/verify-changes-addressed.md new file mode 100644 index 000000000..db888a567 --- /dev/null +++ b/src/data/best-practices/code-review/content/verify-changes-addressed.md @@ -0,0 +1 @@ +# Verify that all the feedback has been addressed by the author. \ No newline at end of file diff --git a/src/data/best-practices/code-review/content/write-automated-tests.md b/src/data/best-practices/code-review/content/write-automated-tests.md new file mode 100644 index 000000000..133da2a32 --- /dev/null +++ b/src/data/best-practices/code-review/content/write-automated-tests.md @@ -0,0 +1 @@ +# Write the automated tests. \ No newline at end of file