Fix accessibility issues

pull/4442/head
Kamran Ahmed 1 year ago
parent c4ef2bfcb4
commit ca32c814da
  1. 1
      src/components/FeaturedItems/MarkFavorite.tsx
  2. 5
      src/components/Footer.astro

@ -96,6 +96,7 @@ export function MarkFavorite({
return ( return (
<button <button
aria-label={isFavorite ? 'Remove from favorites' : 'Add to favorites'}
onClick={toggleFavoriteHandler} onClick={toggleFavoriteHandler}
tabIndex={-1} tabIndex={-1}
className={`${isFavorite ? '' : 'opacity-30 hover:opacity-100'} ${ className={`${isFavorite ? '' : 'opacity-30 hover:opacity-100'} ${

@ -29,10 +29,10 @@ import Icon from './AstroIcon.astro';
href='/about'>FAQs</a href='/about'>FAQs</a
> >
<a <a
aria-label="Subscribe to YouTube channel"
class='px-2 py-1.5 transition-colors hover:text-white sm:border-b-0 sm:px-0 sm:py-0' class='px-2 py-1.5 transition-colors hover:text-white sm:border-b-0 sm:px-0 sm:py-0'
href='https://youtube.com/theroadmap?sub_confirmation=1' href='https://youtube.com/theroadmap?sub_confirmation=1'
target='_blank'>YouTube</a target='_blank'>YouTube</a>
>
</p> </p>
<div class='flex flex-col justify-between gap-12 sm:flex-row'> <div class='flex flex-col justify-between gap-12 sm:flex-row'>
@ -75,6 +75,7 @@ import Icon from './AstroIcon.astro';
<AstroIcon icon='youtube' class='inline-block h-5 w-5' /> <AstroIcon icon='youtube' class='inline-block h-5 w-5' />
</a> </a>
<a <a
aria-label="Follow on Twitter"
href='https://twitter.com/roadmapsh' href='https://twitter.com/roadmapsh'
target='_blank' target='_blank'
class='ml-2 hover:text-white' class='ml-2 hover:text-white'

Loading…
Cancel
Save