Update contribution functionality

pull/4697/head
Kamran Ahmed 11 months ago
parent d103bc629c
commit e0f5d6f436
  1. 12
      src/components/TopicDetail/TopicDetail.tsx
  2. 7
      src/pages/[roadmapId]/[...topicId].astro
  3. 5
      src/pages/best-practices/[bestPracticeId]/[...topicId].astro

@ -45,6 +45,7 @@ export function TopicDetail(props: TopicDetailProps) {
const { canSubmitContribution } = props; const { canSubmitContribution } = props;
const [hasEnoughLinks, setHasEnoughLinks] = useState(false); const [hasEnoughLinks, setHasEnoughLinks] = useState(false);
const [contributionUrl, setContributionUrl] = useState('');
const [isActive, setIsActive] = useState(false); const [isActive, setIsActive] = useState(false);
const [isLoading, setIsLoading] = useState(false); const [isLoading, setIsLoading] = useState(false);
const [isContributing, setIsContributing] = useState(false); const [isContributing, setIsContributing] = useState(false);
@ -160,8 +161,13 @@ export function TopicDetail(props: TopicDetailProps) {
topicHtml, topicHtml,
'text/html', 'text/html',
); );
const links = topicDom.querySelectorAll('a'); const links = topicDom.querySelectorAll('a');
const contributionUrl =
topicDom.querySelector('[data-github-url]')?.dataset?.githubUrl ||
'';
setContributionUrl(contributionUrl);
setHasEnoughLinks(links.length >= 3); setHasEnoughLinks(links.length >= 3);
} else { } else {
setLinks((response as RoadmapContentDocument)?.links || []); setLinks((response as RoadmapContentDocument)?.links || []);
@ -190,8 +196,6 @@ export function TopicDetail(props: TopicDetailProps) {
} }
const hasContent = topicHtml?.length > 0 || links?.length > 0 || topicTitle; const hasContent = topicHtml?.length > 0 || links?.length > 0 || topicTitle;
const dataDir = resourceType === 'roadmap' ? 'roadmaps' : 'best-practices';
const githubBaseUrl = `https://github.com/kamranahmedse/developer-roadmap/tree/master/src/data/${dataDir}/${resourceId}/content`;
return ( return (
<div className={'relative z-50'}> <div className={'relative z-50'}>
@ -281,7 +285,7 @@ export function TopicDetail(props: TopicDetailProps) {
)} )}
{/* Contribution */} {/* Contribution */}
{canSubmitContribution && !hasEnoughLinks && ( {canSubmitContribution && !hasEnoughLinks && contributionUrl && (
<div className="mt-8 flex-1 border-t"> <div className="mt-8 flex-1 border-t">
<p className="mb-2 mt-2 text-sm leading-relaxed text-gray-400"> <p className="mb-2 mt-2 text-sm leading-relaxed text-gray-400">
Help us improve this introduction and submit a link to a good Help us improve this introduction and submit a link to a good
@ -289,7 +293,7 @@ export function TopicDetail(props: TopicDetailProps) {
understand this topic better. understand this topic better.
</p> </p>
<a <a
href={githubBaseUrl} href={contributionUrl}
target={'_blank'} target={'_blank'}
className="flex w-full items-center justify-center rounded-md bg-gray-800 p-2 text-sm text-white transition-colors hover:bg-black hover:text-white disabled:bg-green-200 disabled:text-black" className="flex w-full items-center justify-center rounded-md bg-gray-800 p-2 text-sm text-white transition-colors hover:bg-black hover:text-white disabled:bg-green-200 disabled:text-black"
> >

@ -27,8 +27,13 @@ export async function getStaticPaths() {
export const partial = true; export const partial = true;
const { topicId } = Astro.params; const { topicId } = Astro.params;
const { file, roadmapId, roadmap, heading } = const { file, url, roadmapId, roadmap, heading } =
Astro.props as RoadmapTopicFileType; Astro.props as RoadmapTopicFileType;
const fileWithoutBasePath = file.file?.replace(/.+?\/src\/data/, '/src/data');
const gitHubUrl = `https://github.com/kamranahmedse/developer-roadmap/tree/master${fileWithoutBasePath}`;
--- ---
<div data-github-url={gitHubUrl}></div>
<file.Content /> <file.Content />

@ -21,6 +21,11 @@ export async function getStaticPaths() {
} }
const { file } = Astro.props as BestPracticeTopicFileType; const { file } = Astro.props as BestPracticeTopicFileType;
const fileWithoutBasePath = file.file?.replace(/.+?\/src\/data/, '/src/data');
const gitHubUrl = `https://github.com/kamranahmedse/developer-roadmap/tree/master${fileWithoutBasePath}`;
--- ---
<div data-github-url={gitHubUrl}></div>
<file.Content /> <file.Content />

Loading…
Cancel
Save