fix: bookmark position

feat/favorite
Arik Chakma 1 year ago
parent e18117d669
commit e498b4e0e6
  1. 30
      src/components/BestPracticeHeader.astro
  2. 10
      src/components/RoadmapHeader.astro

@ -22,17 +22,15 @@ const isBestPracticeReady = !isUpcoming;
<div class="border-b"> <div class="border-b">
<div class="container relative py-5 sm:py-12"> <div class="container relative py-5 sm:py-12">
<div class="mb-3 mt-0 sm:mb-6"> <div class="mb-3 mt-0 sm:mb-6">
<div class="flex items-center gap-3"> <h1 class="mb-0.5 text-2xl font-bold sm:mb-2 sm:text-4xl">
<h1 class="mb-0.5 text-2xl font-bold sm:mb-2 sm:text-4xl"> {title}
{title}
</h1>
<MarkFavorite <MarkFavorite
resourceId={bestPracticeId} resourceId={bestPracticeId}
resourceType="best-practice" resourceType="best-practice"
className="text-gray-500 !opacity-100 hover:text-gray-600 [&>svg]:stroke-[1] [&>svg]:stroke-gray-500 hover:[&>svg]:stroke-gray-600 [&>svg]:h-4 [&>svg]:w-4" className="text-gray-500 !opacity-100 hover:text-gray-600 [&>svg]:stroke-[1] [&>svg]:stroke-gray-500 hover:[&>svg]:stroke-gray-600 [&>svg]:h-4 [&>svg]:w-4 ml-2"
client:load client:load
/> />
</div> </h1>
<p class="text-sm text-gray-500 sm:text-lg">{description}</p> <p class="text-sm text-gray-500 sm:text-lg">{description}</p>
</div> </div>
@ -88,16 +86,16 @@ const isBestPracticeReady = !isUpcoming;
{ {
isBestPracticeReady && ( isBestPracticeReady && (
<a <a
href={`https://github.com/kamranahmedse/developer-roadmap/issues/new?title=[Suggestion] ${title}`} href={`https://github.com/kamranahmedse/developer-roadmap/issues/new?title=[Suggestion] ${title}`}
target="_blank" target="_blank"
class="inline-flex items-center justify-center rounded-md bg-gray-500 px-3 py-1.5 text-xs font-medium text-white hover:bg-gray-600 sm:text-sm" class="inline-flex items-center justify-center rounded-md bg-gray-500 px-3 py-1.5 text-xs font-medium text-white hover:bg-gray-600 sm:text-sm"
aria-label="Suggest Changes" aria-label="Suggest Changes"
> >
<Icon icon="comment" class="h-3 w-3" /> <Icon icon="comment" class="h-3 w-3" />
<span class="ml-2 hidden sm:inline">Suggest Changes</span> <span class="ml-2 hidden sm:inline">Suggest Changes</span>
<span class="ml-2 inline sm:hidden">Suggest</span> <span class="ml-2 inline sm:hidden">Suggest</span>
</a> </a>
) )
} }
</div> </div>

@ -41,17 +41,15 @@ const isRoadmapReady = !isUpcoming;
<YouTubeAlert /> <YouTubeAlert />
<div class="mb-3 mt-0 sm:mb-4 sm:mt-4"> <div class="mb-3 mt-0 sm:mb-4 sm:mt-4">
<div class="flex items-center gap-3"> <h1 class="mb-0.5 text-2xl font-bold sm:mb-2 sm:text-4xl">
<h1 class="mb-0.5 text-2xl font-bold sm:mb-2 sm:text-4xl"> {title}
{title}
</h1>
<MarkFavorite <MarkFavorite
resourceId={roadmapId} resourceId={roadmapId}
resourceType="roadmap" resourceType="roadmap"
className="text-gray-500 !opacity-100 hover:text-gray-600 [&>svg]:stroke-[1] [&>svg]:stroke-gray-500 hover:[&>svg]:stroke-gray-600 [&>svg]:h-4 [&>svg]:w-4" className="text-gray-500 !opacity-100 hover:text-gray-600 [&>svg]:stroke-[1] [&>svg]:stroke-gray-500 hover:[&>svg]:stroke-gray-600 [&>svg]:h-4 [&>svg]:w-4 ml-2"
client:load client:load
/> />
</div> </h1>
<p class="text-sm text-gray-500 sm:text-lg">{description}</p> <p class="text-sm text-gray-500 sm:text-lg">{description}</p>
</div> </div>

Loading…
Cancel
Save